Big menu sales! hook_menu needs routing now

Here's a review for the current work:

1. +++ b/devel.module
   @@ -140,11 +137,8 @@ function devel_menu() {
      $items['devel/php'] = array(
        'title' => 'Execute PHP Code',
   

   You can omit the title here and set it in the $form array with $form['#title'].

2. +++ b/devel.routing.yml
   @@ -1,6 +1,21 @@
   +  path: 'devel/php'
   ...
   +  path: 'devel/cache/clear'
   

   Paths should have a leading '/'. I know it's stupid, but that's the "rule" :(

3. +++ b/lib/Drupal/devel/Controller/DevelController.php
   @@ -0,0 +1,27 @@
   +
   +
   

   Extra empty line.

4. +++ b/lib/Drupal/devel/Controller/DevelController.php
   @@ -0,0 +1,27 @@
   +  }
   +}
   

   Missing empty line :)

@pcambra Are there plans to do the other components in here too or are those going to be on separate issues?

#2092529: [meta] Improve DX for defining custom routes this can cause some issues with if (module_exists('taxonomy')) {} in function devel_generate_menu() {

it's acctually this one:
#2091411: Provide an easier mechanism for a route definition wrapped by module_exists()

Here's more on that patch above, hope that helps a bit... not tested

ha whoops, xposted that. oh and did the nitpickery in #3 ;)

I've been working on this and here is my patch

Sorry. This patch is correct.

there are only devel routes and callbacks to it

Moved devel_generate to this one #2113659: Routing YAML for devel_generate

@wodzik could do an interdiff between your changes and @pcambra patch in #2?

That way we can see what you changed?

Here's the interdiff between #2 and #11.

+++ b/devel.module
@@ -42,166 +43,95 @@ function devel_menu() {
-    'title' => 'Clear cache',
...
-    'title' => 'Function reference',
...
-    'title' => 'Reinstall modules',
...
etc

I could be wrong but I was under the impression that the hook_menu needs the 'title' for the Menu Item titles?

You can omit the title here and set it in the $form array with $form['#title'].

The only time you would remove 'title' from hook_menu items would be if it says type=>MENU_CALLBACK. And in that case you wouldn't need the item at all. I'm positive @amateescu is mistaken on that point.

#2047633: Move definition of menu links to hook_menu_link_defaults(), decouple key name from path, and make 'parent' explicit

Some fixes and cleanup, added titles back in, fixed a couple route names, added title args back in. Removed menu items that were only MENU_CALLBACKs and fixed a couple typos/mistakes (menu_name was a route_name and one route had the wrong name in the menu item.

Yep, I didn't take into consideration that the 'devel/php' menu item was actually supposed to show up in a menu. I see now that that's the case, so 'title' needs to be kept in the menu link definition.

Thanks @amateescu for confirming:)

+++ b/devel.routing.yml
@@ -1,6 +1,215 @@
+  path: 'devel/menu/reset'

Missing start path

Fixed #24, and cleaned up in general.

Thanks all for this tough piece of work!

It would be nice to get a green patch before pushing though (if possible).