This is a sub-issue of #1910624: [META] Introduce and complete configuration schemas in all of core.

Problem/motivation

#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. While there are little cleanups planned for the format overall, the current format is a result of months of back and forths, so it should be perfectly fine to apply it more widely to core.

Proposed solution

Create a configuration schema for system.action in system module.

Schema not yet in place
system.action.*
system.file
system.image.gd
system.image
system.mail
system.module
system.theme
system.theme.disabled
system.theme.global

Files: 
CommentFileSizeAuthor
#6 2107689-diff-2-6.txt660 bytesvijaycs85
#6 2107689-system-schema-6.patch10.24 KBvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 59,392 pass(es). View
#2 2107689-system-config-schema-2.patch9.85 KBvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 58,529 pass(es). View

Comments

vijaycs85’s picture

Title: Provide configuration schema for system.action » Complete configuration schema for system module
vijaycs85’s picture

Issue summary: View changes

Updated issue summary.

vijaycs85’s picture

Status: Active » Needs review
Issue tags: +Needs manual testing
FileSize
9.85 KB
PASSED: [[SimpleTest]]: [MySQL] 58,529 pass(es). View

Initial patch.

vijaycs85’s picture

Issue summary: View changes

Updated issue summary.

leeotzu’s picture

Checked the issue and applied the patch. Following schema is not translated back through configuration inspector.

  1. system.authorize
  2. system.date_format.*
  3. - pattern -> mapping -> php
  4. system.fast_404
leeotzu’s picture

Issue summary: View changes
Status: Needs review » Needs work
rych’s picture

I've checked sysrem.performance schema. What I've found:

  • cache.page.enabled is no longer used (I haven't found any reference to it in system module)
  • cache.page.use_internal is missing in schema
  • fast_404 is missing in schema and haven't got any related form element yet
vijaycs85’s picture

Status: Needs work » Needs review
Issue tags: +LONDON_2013_DECEMBER
FileSize
10.24 KB
PASSED: [[SimpleTest]]: [MySQL] 59,392 pass(es). View
660 bytes

Thanks for the reviews @leeotzu and @rych...
Reg #3:
#3.1 - this config has just one element and the value is NULL. So not an issue.
#3.2 - I can see the schema form
#3.3 - There, refer #3.2 screenshot.

#4.1 - yep, removed
#4.2 - yep, added
#4.3 - fast_404 is empty. No elements.

The last submitted patch, 6: 2107689-system-schema-6.patch, failed testing.

The last submitted patch, 6: 2107689-system-schema-6.patch, failed testing.

vijaycs85’s picture

6: 2107689-system-schema-6.patch queued for re-testing.

vijaycs85’s picture

Status: Needs review » Closed (duplicate)
Related issues: +#2167623: Add test for all default configuration to ensure schema exists and is correct

The patch on this issue has been updated as part of #2167623: Add test for all default configuration to ensure schema exists and is correct. As this issue doesn't have any test to confirm/validate the schema, making this change and closing this issue as duplicate of #2167623: Add test for all default configuration to ensure schema exists and is correct. The contributors of this issue (in commit message) has been copied to #2167623: Add test for all default configuration to ensure schema exists and is correct.