This may not be so important in the long term since we are removing all of this code, but it's one less thing to have sitting around in menu.inc

There is a hunk in menu_router_build() that replaces the hook_menu path with the one from the route. If we just make them match we don't have to!

This needs #2102125: Big Local Task Conversion to fix the block demo path.

CommentFileSizeAuthor
#9 menu-2107039-9.patch39.83 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch menu-2107039-9.patch. Unable to apply patch. See the log in the details link for more information. View
#8 menu-2107039-8.patch39.84 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion. View
#6 menu-2107039-6.patch25.77 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] 59,101 pass(es), 1 fail(s), and 0 exception(s). View
#4 menu-2107039-4-exception.patch24.82 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] 58,896 pass(es), 41 fail(s), and 24 exception(s). View
#4 menu-2107039-4-complete.patch25.05 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] 59,033 pass(es), 11 fail(s), and 2 exception(s). View
#2 menu-2107039-2.patch31.38 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] 59,635 pass(es), 1 fail(s), and 1 exception(s). View
#1 menu-2107039-1-delete.patch39.25 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] 58,597 pass(es), 68 fail(s), and 9 exception(s). View
#1 menu-2107039-1-no-access-callback.patch39.22 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] 58,342 pass(es), 52 fail(s), and 9 exception(s). View
#1 menu-2107039-1-no-page-callback.patch39.21 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] 58,743 pass(es), 68 fail(s), and 9 exception(s). View
#1 menu-2107039-1-no-call.patch39.27 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 58,721 pass(es). View
#1 menu-2107039-1-with-exceptions.patch39.53 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 58,786 pass(es). View
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

tim.plunkett’s picture

Status: Active » Needs review
FileSize
39.53 KB
PASSED: [[SimpleTest]]: [MySQL] 58,786 pass(es). View
39.27 KB
PASSED: [[SimpleTest]]: [MySQL] 58,721 pass(es). View
39.21 KB
FAILED: [[SimpleTest]]: [MySQL] 58,743 pass(es), 68 fail(s), and 9 exception(s). View
39.22 KB
FAILED: [[SimpleTest]]: [MySQL] 58,342 pass(es), 52 fail(s), and 9 exception(s). View
39.25 KB
FAILED: [[SimpleTest]]: [MySQL] 58,597 pass(es), 68 fail(s), and 9 exception(s). View

Uploading a couple different approaches to see what breaks and why.

tim.plunkett’s picture

FileSize
31.38 KB
FAILED: [[SimpleTest]]: [MySQL] 59,635 pass(es), 1 fail(s), and 1 exception(s). View

Status: Needs review » Needs work
Issue tags: -MenuSystemRevamp

The last submitted patch, menu-2107039-2.patch, failed testing.

tim.plunkett’s picture

Issue summary: View changes
Status: Needs work » Needs review
FileSize
25.05 KB
FAILED: [[SimpleTest]]: [MySQL] 59,033 pass(es), 11 fail(s), and 2 exception(s). View
24.82 KB
FAILED: [[SimpleTest]]: [MySQL] 58,896 pass(es), 41 fail(s), and 24 exception(s). View

Theme callback went in.

Status: Needs review » Needs work

The last submitted patch, 4: menu-2107039-4-complete.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
25.77 KB
FAILED: [[SimpleTest]]: [MySQL] 59,101 pass(es), 1 fail(s), and 0 exception(s). View

MENU_DEFAULT_LOCAL_TASKS mean we still need some of this.

Status: Needs review » Needs work

The last submitted patch, 6: menu-2107039-6.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
Issue tags: +MenuSystemRevamp
FileSize
39.84 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion. View

This should fix it. And removes a lot of code in the meantime.

tim.plunkett’s picture

FileSize
39.83 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch menu-2107039-9.patch. Unable to apply patch. See the log in the details link for more information. View

Ugh, bad copy/paste

Status: Needs review » Needs work

The last submitted patch, 8: menu-2107039-8.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review

9: menu-2107039-9.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 9: menu-2107039-9.patch, failed testing.

tim.plunkett’s picture

dawehner’s picture

This basically touches a lot of similar lines to https://drupal.org/node/2047633 .

tim.plunkett’s picture

Yeah I'll just leave this postponed until all of that is done. This is not urgent, just cleanup.

amateescu’s picture

Status: Postponed » Closed (duplicate)

I think #2177041: Remove all implementations of hook_menu makes this issue obsolete.