Updated: Comment 0

Problem/Motivation

Flood/MemoryBackend relies on using floats as array keys, which will always be upcasted to ints. The current webtest
just calls register() which is kind of a pointless flood control.

Proposed resolution

  • Fix the actual bug
  • Remove the webtest, as it is slow anyway and replace it with a unit test

Remaining tasks

User interface changes

API changes

Files: 
CommentFileSizeAuthor
#1 flood-2106939-1.patch4.19 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] 58,373 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

Comments

dawehner’s picture

Status:Active» Needs review
StatusFileSize
new4.19 KB
FAILED: [[SimpleTest]]: [MySQL] 58,373 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

This shows that there is a bug.

The last submitted patch, flood-2106939-1.patch, failed testing.

pwolanin’s picture

Title:MemoryBackendTest fails when called multiple times.» Flood/MemoryBackendTest fails when called multiple times in .
Issue summary:View changes

update title for clarity