Updated: Comment 0

Problem/Motivation

Flood/MemoryBackend relies on using floats as array keys, which will always be upcasted to ints. The current webtest
just calls register() which is kind of a pointless flood control.

Proposed resolution

  • Fix the actual bug
  • Remove the webtest, as it is slow anyway and replace it with a unit test

Remaining tasks

User interface changes

API changes

Files: 
CommentFileSizeAuthor
#1 flood-2106939-1.patch4.19 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] 58,373 pass(es), 2 fail(s), and 0 exception(s). View

Comments

dawehner’s picture

Status: Active » Needs review
FileSize
4.19 KB
FAILED: [[SimpleTest]]: [MySQL] 58,373 pass(es), 2 fail(s), and 0 exception(s). View

This shows that there is a bug.

The last submitted patch, flood-2106939-1.patch, failed testing.

pwolanin’s picture

Title: MemoryBackendTest fails when called multiple times. » Flood/MemoryBackendTest fails when called multiple times in .
Issue summary: View changes

update title for clarity

andypost’s picture

suppose both should be converted to kernel test

dawehner’s picture

Well the memory backend one is actually fine for to be a pure unit test.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.