Follow-up from #1653026: [META] Use properly typed values in module configuration.

Problem/Motivation

All integers, Booleans, and even octal numbers in config object files are converted to strings.

Proposed resolution

#1653026: [META] Use properly typed values in module configuration has fixed core, so no need to convert all data types to string anymore.

Remaining tasks

update.settings.yml
update_test.settings.yml

User interface changes

NO

API changes

NO

Parent: #1653026: [META] Use properly typed values in module configuration

Files: 
CommentFileSizeAuthor
#7 2106009-update-config-cleanup-7.patch794 bytesvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 59,363 pass(es).
[ View ]

Comments

danilenko_dn’s picture

Status:Active» Needs review
StatusFileSize
new3.49 KB
FAILED: [[SimpleTest]]: [MySQL] 57,528 pass(es), 343 fail(s), and 192 exception(s).
[ View ]
danilenko_dn’s picture

Assigned:Unassigned» danilenko_dn

Status:Needs review» Needs work
Issue tags:-Configuration system, -YAML

The last submitted patch, 2106009-1.patch, failed testing.

danilenko_dn’s picture

Status:Needs work» Needs review

#1: 2106009-1.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+Configuration system, +YAML

The last submitted patch, 2106009-1.patch, failed testing.

vijaycs85’s picture

  1. +++ b/core/modules/update/tests/modules/update_test/update_test.routing.yml
    @@ -3,7 +3,7 @@ update_test.503:
    -    _access: 'TRUE'
    +    _access: TRUE

    +++ b/core/modules/update/update.routing.yml
    @@ -28,7 +28,7 @@ update.report_install:
    -    _access_update_manager: 'TRUE'
    +    _access_update_manager: TRUE

    @@ -39,7 +39,7 @@ update.report_update:
    -    _access_update_manager: 'TRUE'
    +    _access_update_manager: TRUE

    @@ -49,7 +49,7 @@ update.module_install:
    -    _access_update_manager: 'TRUE'
    +    _access_update_manager: TRUE

    @@ -60,7 +60,7 @@ update.module_update:
    -    _access_update_manager: 'TRUE'
    +    _access_update_manager: TRUE

    @@ -70,7 +70,7 @@ update.theme_install:
    -    _access_update_manager: 'TRUE'
    +    _access_update_manager: TRUE

    @@ -81,7 +81,7 @@ update.theme_update:
    -    _access_update_manager: 'TRUE'
    +    _access_update_manager: TRUE

    @@ -92,4 +92,4 @@ update.confirmation_page:
    -    _access_update_manager: 'TRUE'
    +    _access_update_manager: TRUE

    Sorry, don't update update router file. Removing it from issue summary.

vijaycs85’s picture

Issue summary:View changes

Updated issue summary.

vijaycs85’s picture

Issue summary:View changes
Status:Needs work» Needs review
StatusFileSize
new794 bytes
PASSED: [[SimpleTest]]: [MySQL] 59,363 pass(es).
[ View ]

Re-rolling...

vijaycs85’s picture

Status:Needs review» Closed (duplicate)
Related issues:+#2167623: Add test for all default configuration to ensure schema exists and is correct

The patch on this issue has been updated as part of #2167623: Add test for all default configuration to ensure schema exists and is correct. As this issue doesn't have any test to confirm/validate the schema, making this change and closing this issue as duplicate of #2167623: Add test for all default configuration to ensure schema exists and is correct. The contributors of this issue (in commit message) is copied to #2167623: Add test for all default configuration to ensure schema exists and is correct.