Follow-up from #1653026: [META] Use properly typed values in module configuration.
Problem/Motivation
All integers, Booleans, and even octal numbers in config object files are converted to strings.
Proposed resolution
#1653026: [META] Use properly typed values in module configuration has fixed core, so no need to convert all data types to string anymore.
Remaining tasks
Fix and issue patch for below config files:
comment.local_tasks.yml
comment.routing.yml
entity.view_mode.comment.full.yml
system.action.comment_publish_action.yml
system.action.comment_save_action.yml
system.action.comment_unpublish_action.yml
views.view.test_comment_row.yml
views.view.test_comment_rss.yml
views.view.test_comment_user_uid.yml
User interface changes
NO
API changes
NO
Related Issues
Parent: #1653026: [META] Use properly typed values in module configuration
Comment | File | Size | Author |
---|---|---|---|
#6 | 2105921-config-fix-comment-6.patch | 7.87 KB | vijaycs85 |
#5 | 2105921-config-fix-comment-5.patch | 7.88 KB | vijaycs85 |
#5 | 2105921-diff-3-5.txt | 3.41 KB | vijaycs85 |
#3 | 2105921-3.patch | 7.78 KB | sidharthap |
#1 | 2105921-1.patch | 10.85 KB | sidharthap |
Comments
Comment #1
sidharthapinitial patch
Comment #2
vijaycs85Thanks for the patch @sidharthap.
All boolean should be lower true or false.
Comment #3
sidharthapThank you for the review @Vijaycs85
corrected #2 comment.
Comment #4
enhdless CreditAttribution: enhdless commentedAs Vijaycs85 mentioned in #2, boolean 1's and 0's should be true or false instead.
Comment #5
vijaycs85Updating config file...
Comment #6
vijaycs85Updated group to int
Comment #7
vijaycs856: 2105921-config-fix-comment-6.patch queued for re-testing.
Comment #8
vijaycs85The patch on this issue has been updated as part of #2167623: Add test for all default configuration to ensure schema exists and is correct. As this issue doesn't have any test to confirm/validate the schema, making this change and closing this issue as duplicate of #2167623: Add test for all default configuration to ensure schema exists and is correct. The contributors of this issue (in commit message) is copied to #2167623: Add test for all default configuration to ensure schema exists and is correct.