Follow-up from #1653026: [META] Use properly typed values in module configuration.

Problem/Motivation

All integers, Booleans, and even octal numbers in config object files are converted to strings.

Proposed resolution

#1653026: [META] Use properly typed values in module configuration has fixed core, so no need to convert all data types to string anymore.

Remaining tasks

Fix and issue patch for below config files:
entity.view_mode.node.print.yml
node.type.book.yml

User interface changes

NO

API changes

NO

Parent: #1653026: [META] Use properly typed values in module configuration

Files: 
CommentFileSizeAuthor
#5 2105917-book-config-cleanup-5.patch1.42 KBvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 59,304 pass(es). View
#3 2105917-book-yml-type-casting-1.patch1.17 KBvijaycs85
FAILED: [[SimpleTest]]: [MySQL] 58,875 pass(es), 1 fail(s), and 0 exception(s). View
#1 2105917-book-yml-type-casting-1.patch1.55 KBvijaycs85
FAILED: [[SimpleTest]]: [MySQL] 57,364 pass(es), 64 fail(s), and 139 exception(s). View

Comments

vijaycs85’s picture

Status: Active » Needs review
FileSize
1.55 KB
FAILED: [[SimpleTest]]: [MySQL] 57,364 pass(es), 64 fail(s), and 139 exception(s). View

Initial patch...

Status: Needs review » Needs work

The last submitted patch, 2105917-book-yml-type-casting-1.patch, failed testing.

vijaycs85’s picture

Title: Make sure all YML files in Book module has no type-casting to string. » Make sure all config yml files in Book module has no type-casting to string.
Status: Needs work » Needs review
FileSize
1.17 KB
FAILED: [[SimpleTest]]: [MySQL] 58,875 pass(es), 1 fail(s), and 0 exception(s). View

Removing routing changes as they are not related to this (Ref: #2105993-5: Make sure all Config yml files in System module has no type-casting to string. ).

The last submitted patch, 2105917-book-yml-type-casting-1.patch, failed testing.

vijaycs85’s picture

Issue summary: View changes
Status: Needs work » Needs review
FileSize
1.42 KB
PASSED: [[SimpleTest]]: [MySQL] 59,304 pass(es). View

Re-rolling...

vijaycs85’s picture

Status: Needs review » Closed (duplicate)
Related issues: +#2167623: Add test for all default configuration to ensure schema exists and is correct

The patch on this issue has been updated as part of #2167623: Add test for all default configuration to ensure schema exists and is correct. As this issue doesn't have any test to confirm/validate the schema, making this change and closing this issue as duplicate of #2167623: Add test for all default configuration to ensure schema exists and is correct. The contributors of this issue (in commit message) is copied to #2167623: Add test for all default configuration to ensure schema exists and is correct.