Follow-up from #1653026: [META] Use properly typed values in module configuration.

Problem/Motivation

All integers, Booleans, and even octal numbers in config object files are converted to strings.

Proposed resolution

#1653026: [META] Use properly typed values in module configuration has fixed core, so no need to convert all data types to string anymore.

Remaining tasks

Fix and issue patch for below config files:
aggregator.settings.yml
views.view.aggregator_rss_feed.yml
views.view.test_aggregator_items.yml

User interface changes

NO

API changes

NO

Parent: #1653026: [META] Use properly typed values in module configuration

Files: 
CommentFileSizeAuthor
#7 2105913-aggregator-config-cleanup-7.patch5.3 KBvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 59,305 pass(es).
[ View ]
#4 2105913-aggregator-yml-type-casting-4.patch1.99 KBkrishnan.n
PASSED: [[SimpleTest]]: [MySQL] 59,533 pass(es).
[ View ]
#3 2105913-aggregator-yml-type-casting-3.patch11.44 KBvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 58,685 pass(es).
[ View ]

Comments

vijaycs85’s picture

Title:Make sure all YML files in action/action_bulk_test module has no type-casting to string.» Make sure all YML files in aggregator module has no type-casting to string.
vijaycs85’s picture

Title:Make sure all YML files in aggregator module has no type-casting to string.» Make sure all YML files in Aggregator module has no type-casting to string.
vijaycs85’s picture

Status:Active» Needs review
StatusFileSize
new11.44 KB
PASSED: [[SimpleTest]]: [MySQL] 58,685 pass(es).
[ View ]

Initial patch...

krishnan.n’s picture

StatusFileSize
new1.99 KB
PASSED: [[SimpleTest]]: [MySQL] 59,533 pass(es).
[ View ]

Pl see script here : 21059

twistor’s picture

@krishnan.n, your script isn't working quite right, since keys like items_per_page should become integers, not booleans.

mtift’s picture

Status:Needs review» Needs work

#5 means that this needs work.

Rather than running scripts we should be saving the view in the ui and copying the saved .yml back to the aggregator's config directory.

vijaycs85’s picture

Issue summary:View changes
Status:Needs work» Needs review
StatusFileSize
new5.3 KB
PASSED: [[SimpleTest]]: [MySQL] 59,305 pass(es).
[ View ]

Re-rolling...

vijaycs85’s picture

Status:Needs review» Closed (duplicate)
Related issues:+#2167623: Add test for all default configuration to ensure schema exists and is correct

The patch on this issue has been updated as part of #2167623: Add test for all default configuration to ensure schema exists and is correct. As this issue doesn't have any test to confirm/validate the schema, making this change and closing this issue as duplicate of #2167623: Add test for all default configuration to ensure schema exists and is correct. The contributors of this issue (in commit message) is copied to #2167623: Add test for all default configuration to ensure schema exists and is correct.