Files: 
CommentFileSizeAuthor
#4 inject-config-factory-2105621-4.patch5.36 KBclaudiu.cristea
PASSED: [[SimpleTest]]: [MySQL] 58,451 pass(es). View
#4 interdiff.txt510 bytesclaudiu.cristea
#3 inject-config-factory-2105621-3.patch5.17 KBclaudiu.cristea
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion. View
#3 interdiff.txt1.84 KBclaudiu.cristea
#1 inject-config-factory-2105621-1.patch3.2 KBclaudiu.cristea
FAILED: [[SimpleTest]]: [MySQL] 58,459 pass(es), 2 fail(s), and 34 exception(s). View

Comments

claudiu.cristea’s picture

Status: Active » Needs review
FileSize
3.2 KB
FAILED: [[SimpleTest]]: [MySQL] 58,459 pass(es), 2 fail(s), and 34 exception(s). View

Here's a patch.

Status: Needs review » Needs work

The last submitted patch, inject-config-factory-2105621-1.patch, failed testing.

claudiu.cristea’s picture

Status: Needs work » Needs review
FileSize
1.84 KB
5.17 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion. View

Forgot to change in tests.

claudiu.cristea’s picture

FileSize
510 bytes
5.36 KB
PASSED: [[SimpleTest]]: [MySQL] 58,451 pass(es). View

Cleaned also an unused use statement.

claudiu.cristea’s picture

Created a meta-issue for all image work here #2105863: [meta] Images, toolkits and operations.

mr.baileys’s picture

Status: Needs review » Reviewed & tested by the community

Looks good!

webchick’s picture

Committed and pushed to 8.x. Thanks!

Off-topic: Want to put yourself down for image module in MAINTAINERS.txt? :) seems like you're doing a bunch of work on it.

claudiu.cristea’s picture

Re on #7: OK :)

claudiu.cristea’s picture

Assigned: claudiu.cristea » Unassigned

Can we set this to 'fixed' now?

mr.baileys’s picture

Status: Reviewed & tested by the community » Fixed

Yup, commit: http://drupalcode.org/project/drupal.git/commit/6207fe9 and no additional work to be done...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.