In toolbar module we have toolbar.settings.yml which contains the list of breakpoints provided by the toolbar module -

- module.toolbar.narrow
- module.toolbar.standard
- module.toolbar.wide

The breakpoint module does not actually look for this file (it picks up toolbar.breakpoints.yml - which also has the breakpoint configuration).
I may be wrong but it also seems like this is not used anywhere in the code as the breakpoint module will currently create a breakpoint group if one does not already exists, or, it will look for MODULE.breakpoint_groups.yml

Providing a patch which removes this seemingly redundant config file.

#1 remove-breakpoints-settings-yml.patch961 bytestayzlor
PASSED: [[SimpleTest]]: [MySQL] 58,438 pass(es). View


tayzlor’s picture

Status: Active » Needs review
961 bytes
PASSED: [[SimpleTest]]: [MySQL] 58,438 pass(es). View

and here is the patch...

vijaycs85’s picture

It looks good. if test bot comes green, we are good :) lesscode++

areke’s picture

Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +Needs reroll

Once the patch at #1 gets rebased, this should be good.

vijaycs85’s picture

Status: Needs work » Closed (won't fix)

Don't have toolbar.settings.yml anymore. all breakpoint covered in breakpoint module