Updated: Comment #0

Problem/Motivation

\Drupal\Component\Utility\Xss::split has argument $store. The comment 'whether to store $m' is not descriptive enough.

Proposed resolution

Expand the description of this argument.

Remaining tasks

Patch
Review

User interface changes

None

API changes

None

Follow-up from #2100397: [meta] Ensure that DX issues identified by a recent review are covered with individual issues.

Files: 
CommentFileSizeAuthor
#8 xss-split.2.patch2.83 KBlarowlan
PASSED: [[SimpleTest]]: [MySQL] 58,588 pass(es).
[ View ]
#6 xss-split.reroll.patch1.97 KBlarowlan
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: PHP Fatal error encountered during run_tests.sh. See review log for details..
[ View ]
#4 xss.patch2.02 KBlarowlan
FAILED: [[SimpleTest]]: [MySQL] Invalid patch format in xss_0.patch.
[ View ]
#3 interdiff.txt2.46 KBlarowlan
#3 xss-split.2.patch2.83 KBlarowlan
PASSED: [[SimpleTest]]: [MySQL] 58,422 pass(es).
[ View ]
#1 cleanup-xss-split.patch2.98 KBlarowlan
FAILED: [[SimpleTest]]: [MySQL] 58,760 pass(es), 112 fail(s), and 0 exception(s).
[ View ]

Comments

larowlan’s picture

Title:Clarify argument description 'whether to store $m' in \Drupal\Component\Utility\Xss» Don't rely on internal function statics in \Drupal\Component\Utility\Xss::split()
Component:documentation» base system
Priority:Minor» Normal
Status:Active» Needs review
StatusFileSize
new2.98 KB
FAILED: [[SimpleTest]]: [MySQL] 58,760 pass(es), 112 fail(s), and 0 exception(s).
[ View ]

Should we even be using internal function statics on an object?
Lets see what tests say.

Status:Needs review» Needs work

The last submitted patch, cleanup-xss-split.patch, failed testing.

larowlan’s picture

Status:Needs work» Needs review
StatusFileSize
new2.83 KB
PASSED: [[SimpleTest]]: [MySQL] 58,422 pass(es).
[ View ]
new2.46 KB

Yeah didn't really pay attention there did I

larowlan’s picture

StatusFileSize
new2.02 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid patch format in xss_0.patch.
[ View ]

New version suggested by @dawehner in irc

Status:Needs review» Needs work

The last submitted patch, xss.patch, failed testing.

larowlan’s picture

Status:Needs work» Needs review
StatusFileSize
new1.97 KB
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: PHP Fatal error encountered during run_tests.sh. See review log for details..
[ View ]

Status:Needs review» Needs work

The last submitted patch, xss-split.reroll.patch, failed testing.

larowlan’s picture

Status:Needs work» Needs review
StatusFileSize
new2.83 KB
PASSED: [[SimpleTest]]: [MySQL] 58,588 pass(es).
[ View ]

"Fatal error: Cannot access static:: when no class scope is active in /var/lib/drupaltestbot/sites/default/files/checkout/core/lib/Drupal/Component/Utility/Xss.php"
so back to approach of #3

olli’s picture

larowlan’s picture

Status:Needs review» Closed (duplicate)

Duplicate