Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When cache for anonymous users is active, the form is not refreshed after an answer is added, update or delete. This can lead to multiple inputs and misundestandings.
Patch is coming.
Comments
Comment #1
DuaelFrPlease test it carefully because I coded it without a running instance ;)
This patch is part of the #1day1patch initiative.
Comment #2
Pomliane CreditAttribution: Pomliane commentedThanks DuaelFR for the patch!
Unfortunately, it does not seem to work here.
Comment #3
DuaelFrHere is the new working one...
Fucking trailing slashes... :D
Comment #4
Pomliane CreditAttribution: Pomliane commentedWorks here too! :)
Comment #5
DuaelFrMinor performances improvement.
Comment #6
DuaelFrHmm... This is better...
The previous patch never existed.
Comment #7
DuaelFrLet's improve it again !
This now includes Entity Cache support.
Enjoy !
Comment #8
SebCorbin CreditAttribution: SebCorbin commentedRerolled and replaced
'/'
by the correct function (base_path) so that it works in subdirectories.I wonder if we should simply use
cache_clear_all()
as it is actually done in node_save()...Comment #9
DuaelFrThere is no
base_path()
function in your patch but it is a good idea !I think it would be a bad idea to use
cache_clear_all()
here because of performances issues on websites that could use this module intensely. Imagine Doodle clearing all cache each time an answer is posted, edited or deleted... Moreover,cache_clear_all()
only clean page and block cache, not Entity Cache.Comment #10
SebCorbin CreditAttribution: SebCorbin commentedCommitted as is (with base_path) and credited, thanks :)
Comment #12
DuaelFrReoppening to better handle the entity cache and fix an issue if the page showing the form is using an alias.
This patch has been made on the current dev version obviously.
Comment #13
DuaelFrAnother big patch to also clear the cache of entities that would reference the entity having the makemeeting field using the Entity Reference module.
Review carefully.
Comment #14
Pomliane CreditAttribution: Pomliane commentedWorks well here, many thanks DuaelFr!
Comment #16
SebCorbin CreditAttribution: SebCorbin commented