Sub-issue for meta issue #1880976: [meta] Port examples (including submodules) to D9.4+

Problem/Motivation

D8 all the things!

Proposed resolution

Start with D7 version and figure out how to port ;)

CommentFileSizeAuthor
#23 interdiff.txt20 KBMile23
#23 2102661_23.patch27.35 KBMile23
#21 interdiff-21.txt441 bytesjoshi.rohit100
#21 2102661-21.patch27.43 KBjoshi.rohit100
#19 interdiff-19.txt571 bytesjoshi.rohit100
#19 2102661-19.patch27.37 KBjoshi.rohit100
#16 interdiff-16.txt485 bytesjoshi.rohit100
#16 2102661-16.patch27.39 KBjoshi.rohit100
#14 interdiff-14.txt2.55 KBjoshi.rohit100
#14 2102661-14.patch26.91 KBjoshi.rohit100
#12 2102661-12.patch27.08 KBrpayanm
#12 2102661-interdiff.txt477 bytesrpayanm
#9 2102661-9.patch27.04 KBrpayanm
#9 2102661-interdiff.txt356 bytesrpayanm
#4 2102661-4.patch27.02 KBrpayanm
#4 2102661-interdiff.txt13.54 KBrpayanm
#2 examples-image-port-d8-2.patch28.14 KBvijaycs85

Issue fork examples-2102661

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Assigned: Unassigned » vijaycs85
Issue summary: View changes

Going to try this one...

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Assigned: vijaycs85 » Unassigned
Status: Active » Needs work
FileSize
examples-image-port-d8-2.patch28.14 KB

Initial patch. Still needs more work. Just adding here, if anyone want to pick it before I start progressing...

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented 
  1. +++ b/image_example/image_example.routing.yml
@@ -0,0 +1,15 @@
+  $items[''] = array(
+    'title' => '',
+    'page callback' => 'drupal_get_form',
+    'page arguments' => array(''),
+    'access arguments' => array(''),
+    'file' => 'image_example.pages.inc',
+  );

    Need to removed.... 

  2. +++ b/image_example/src/Form/StyleForm.php
@@ -0,0 +1,153 @@
\ No newline at end of file

    oops 

  3. +++ b/image_example/src/Plugin/ImageEffect/ColorizeImageEffect.php
@@ -0,0 +1,159 @@
+ *     // Human readable name of the effect.
+'label' => $this->t(''),
+// (optional) Brief description of the effect that will be shown when
+// adding or configuring this image effect.
+'help' => $this->t(''),
+// Name of function called to perform this effect.
...
+'summary theme' => 'image_example_colorize_summary',

    Need to be removed... 

  4. +++ b/image_example/src/Plugin/ImageEffect/ColorizeImageEffect.php
@@ -0,0 +1,159 @@
\ No newline at end of file

    again...

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
CreditAttribution: rpayanm at SeeD EM commented
FileSize
2102661-interdiff.txt13.54 KB
2102661-4.patch27.02 KB

Another progress...

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Status: Needs work » Needs review
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Status: Needs review » Needs work

The patch still applies (since it's making a new module), but it doesn't appear in the module list to enable.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
CreditAttribution: joshi.rohit100 commented
Assigned: Unassigned » joshi.rohit100
joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
CreditAttribution: joshi.rohit100 commented
Assigned: joshi.rohit100 » Unassigned
rpayanm’s picture

rpayanm
he/him
Primary language Spanish
CreditAttribution: rpayanm at SeeD EM commented
Status: Needs work » Needs review
FileSize
2102661-interdiff.txt356 bytes
2102661-9.patch27.04 KB

Umm missing:

type: module

Status: Needs review » Needs work

The last submitted patch, 9: 2102661-9.patch, failed testing.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
CreditAttribution: joshi.rohit100 commented

I think, instead of using config factory in submit, we should use getEditbale... method

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
CreditAttribution: rpayanm at SeeD EM commented
Status: Needs work » Needs review
FileSize
2102661-interdiff.txt477 bytes
2102661-12.patch27.08 KB

I think, instead of using config factory in submit, we should use getEditbale... method

@joshi.rohit100 you could give an example, please.

Status: Needs review » Needs work

The last submitted patch, 12: 2102661-12.patch, failed testing.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
CreditAttribution: joshi.rohit100 commented
Status: Needs work » Needs review
FileSize
2102661-14.patch26.91 KB
interdiff-14.txt2.55 KB

lets first fix the tests.

Status: Needs review » Needs work

The last submitted patch, 14: 2102661-14.patch, failed testing.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
CreditAttribution: joshi.rohit100 commented
FileSize
2102661-16.patch27.39 KB
interdiff-16.txt485 bytes
joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
CreditAttribution: joshi.rohit100 commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 16: 2102661-16.patch, failed testing.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
CreditAttribution: joshi.rohit100 commented
Status: Needs work » Needs review
FileSize
2102661-19.patch27.37 KB
interdiff-19.txt571 bytes

Status: Needs review » Needs work

The last submitted patch, 19: 2102661-19.patch, failed testing.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
CreditAttribution: joshi.rohit100 commented
Status: Needs work » Needs review
FileSize
2102661-21.patch27.43 KB
interdiff-21.txt441 bytes

hoping for green

Status: Needs review » Needs work

The last submitted patch, 21: 2102661-21.patch, failed testing.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Status: Needs work » Needs review
FileSize
2102661_23.patch27.35 KB
interdiff.txt20 KB

Fixed some typos, CS improvements, moved test to BTB.

Still a lot to do, such as l(), t(), and drupal_set_message().

I see this error on testing:

1) Drupal\Tests\image_example\Functional\ImageExampleTest::testImageExample
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for image_example.settings with the following errors: image_example.settings:_core missing schema

This leads me to believe that we need to tweak something in config/schema/ and/or config/install/.

Also the form you eventually see doesn't explain itself, and doesn't seem to do anything. It fails to upload an image and errors out.

We might also change the name of this to image_style_example.

Status: Needs review » Needs work

The last submitted patch, 23: 2102661_23.patch, failed testing. View results

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Title: Port image_example module to Drupal 8 » Port image_example module to Drupal 9.4+
Version: 8.x-1.x-dev » 4.0.x-dev

4.0.x is the active dev branch

jungle opened merge request !22