Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Sub-issue for meta issue #1880976: [meta] Port examples (including submodules) to D9.4+
Problem/Motivation
D8 all the things!
Proposed resolution
Start with D7 version and figure out how to port ;)
Comment | File | Size | Author |
---|---|---|---|
#14 | interdiff.txt | 7.46 KB | marvil07 |
#14 | 0001-Issue-2102621-by-pferlito-marvil07-Port-email_exampl.patch | 13.08 KB | marvil07 |
Comments
Comment #1
Kristen PolComment #1.0
Kristen PolUpdated issue summary.
Comment #2
Kristen PolComment #3
Anonymous (not verified) CreditAttribution: Anonymous commentedComment #4
Mile23Rock on, pferlito. :-)
Comment #5
Anonymous (not verified) CreditAttribution: Anonymous commentedFirst attempt.
Comment #6
Mile23Nice start. Just a few things...
package: Examples
and
version: 8.x-1.x
We want to avoid these kinds of comments. Put documentation in the docblocks so api.drupal.org can find them, or inline with the code so people can read them.
Spaces not tabs. :-)
Examples is more of a documentation project than a code one. We want to explain the hows and whys of implementing stuff, so as a rule of thumb, @inheritdoc should be replaced with 'We're overriding this method because....'
Also, no tests. Even a functional SimpleTest to make sure the module can be enabled without blowing up would be good.
Thanks.
Comment #7
Mile23Comment #8
Anonymous (not verified) CreditAttribution: Anonymous commentedTahnks @Mile23. Here is an updated patch. I made the corrections and added a test.
Comment #9
Anonymous (not verified) CreditAttribution: Anonymous commentedComment #11
Anonymous (not verified) CreditAttribution: Anonymous commentedLooking at the details here looks like my code passed testing. The error is coming from the page example module.
Comment #12
Anonymous (not verified) CreditAttribution: Anonymous commentedComment #13
marvil07 CreditAttribution: marvil07 commented#8: email_example-2102621-8.patch queued for re-testing.
Comment #13.0
marvil07 CreditAttribution: marvil07 commentedUpdated issue summary.
Comment #14
marvil07 CreditAttribution: marvil07 commented@pferlito: Thanks for the patches!
What is new in this patch:
I will add this after testbot agrees.
Comment #15
marvil07 CreditAttribution: marvil07 commentedMail example added!