Remove drupal_set_title in filter module controllers [#2102451]

Subtask of #1830588: [META] remove drupal_set_title() and drupal_get_title()

Problem/Motivation

Using procedural drupal_set_title() inside controller class is not encouraged.

Proposed resolution

Replace drupal_set_title() with #title in page return array.

Remaining tasks

Issue patch

User interface changes

Refer parent issue at #1830588: [META] remove drupal_set_title() and drupal_get_title()

API changes

Refer parent issue at #1830588: [META] remove drupal_set_title() and drupal_get_title()

Comment	File	Size	Author
#5	2102451-filter-title-5.patch	1.74 KB	sidharthap
#5
#1	2102451-filter-title-1.patch	1.37 KB	vijaycs85
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 4 October 2013 at 16:11

Status:

Active

» Needs review

File	Size
2102451-filter-title-1.patch	1.37 KB

Initial patch...

Comment #2

4 October 2013 at 17:11

Status:	Needs review	» Needs work
Issue tags:	-WSCCI Conversions

The last submitted patch, 2102451-filter-title-1.patch, failed testing.

Comment #3

InternetDevels CreditAttribution: InternetDevels commented 5 October 2013 at 12:34

Status:	Needs work	» Needs review
Issue tags:		+WSCCI Conversions

#1: 2102451-filter-title-1.patch queued for re-testing.

Comment #4

dawehner

German

CreditAttribution: dawehner commented 20 October 2013 at 18:26

Status:

Needs review

» Needs work

+++ b/core/modules/filter/lib/Drupal/filter/FilterFormatAddFormController.php
@@ -16,7 +16,7 @@ class FilterFormatAddFormController extends FilterFormatFormControllerBase {
   public function form(array $form, array &$form_state) {
-    drupal_set_title('Add text format');
+    $form['#title'] = $this->t('Add text format');
     return parent::form($form, $form_state);
   }

I think we should just put the title onto the route definition here.