Subtask of #1830588: [META] remove drupal_set_title() and drupal_get_title()

Problem/Motivation

Using procedural drupal_set_title() inside controller class is not encouraged.

Proposed resolution

Replace drupal_set_title() with #title in page return array.

Remaining tasks

Issue patch

User interface changes

Refer parent issue at #1830588: [META] remove drupal_set_title() and drupal_get_title()

API changes

Refer parent issue at #1830588: [META] remove drupal_set_title() and drupal_get_title()

CommentFileSizeAuthor
#8 drupal8.entity-system.2102447-8.patch3.95 KBACF
#5 drupal8.entity-system.2102447-5.patch3.94 KBdisasm
#5 interdiff.txt1.32 KBdisasm
#4 drupal8.entity-system.2102447-4.patch4.06 KBdisasm
#4 interdiff.txt739 bytesdisasm
#1 2102447-entity-title-1.patch3.99 KBvijaycs85
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
FileSize
2102447-entity-title-1.patch3.99 KB

Initial patch...

marcingy’s picture

marcingy CreditAttribution: marcingy commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2102447-entity-title-1.patch, failed testing.

disasm’s picture

disasm CreditAttribution: disasm commented
Status: Needs work » Needs review
FileSize
interdiff.txt739 bytes
drupal8.entity-system.2102447-4.patch4.06 KB

There was a form['#title'] never being returned. Fixed the order of statements to make sure it got returned.

disasm’s picture

disasm CreditAttribution: disasm commented
FileSize
interdiff.txt1.32 KB
drupal8.entity-system.2102447-5.patch3.94 KB

Since getTitle is only called in buildForm and getTitle is two lines, just got rid of the function altogether.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Perfect!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Patch no longer applies.

ACF’s picture

ACF CreditAttribution: ACF commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
drupal8.entity-system.2102447-8.patch3.95 KB

Just a reroll of patch 5. I guess this can go back to rtbc if it goes green.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +London_2013_October

Thanks @AFC, looks good to me.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.