I'm not sure where this is coming from. Head to /admin to see see the button.

install.php_2.diff.png

Files: 
CommentFileSizeAuthor
#9 update-2102357-9-FAIL.patch1.69 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] 58,435 pass(es), 2 fail(s), and 0 exception(s).
[ View ]
#9 update-2102357-9-PASS.patch2.4 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 58,787 pass(es).
[ View ]
#8 theme-action-2102357-8.patch745 bytesLewisNyman
PASSED: [[SimpleTest]]: [MySQL] 58,671 pass(es).
[ View ]
#3 theme-action-2102357-3.patch896 bytesLewisNyman
FAILED: [[SimpleTest]]: [MySQL] 58,787 pass(es), 26 fail(s), and 74 exception(s).
[ View ]
install.php_2.diff.png48.37 KBLewisNyman

Comments

LewisNyman’s picture

Title:“Install new theme” action link appear on /admin» “Install new theme” action link appears on /admin
LewisNyman’s picture

Component:system.module» update.module

This is actually related to the update module. Looking around, I guess they sit here because there is no admin/theme path?

LewisNyman’s picture

StatusFileSize
new896 bytes
FAILED: [[SimpleTest]]: [MySQL] 58,787 pass(es), 26 fail(s), and 74 exception(s).
[ View ]

I figured it out! Who said this new routing system was hard work?

LewisNyman’s picture

Status:Active» Needs review

Status:Needs review» Needs work

The last submitted patch, theme-action-2102357-3.patch, failed testing.

LewisNyman’s picture

Status:Needs work» Needs review

#3: theme-action-2102357-3.patch queued for re-testing.

Status:Needs review» Needs work

The last submitted patch, theme-action-2102357-3.patch, failed testing.

LewisNyman’s picture

Status:Needs work» Needs review
StatusFileSize
new745 bytes
PASSED: [[SimpleTest]]: [MySQL] 58,671 pass(es).
[ View ]

I couldn't find any references to these paths that could be breaking the tests. I don't actually need to change the key so let's try that.

tim.plunkett’s picture

StatusFileSize
new2.4 KB
PASSED: [[SimpleTest]]: [MySQL] 58,787 pass(es).
[ View ]
new1.69 KB
FAILED: [[SimpleTest]]: [MySQL] 58,435 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

It doesn't help when all the test does is assert text DOESN'T show up, and then the page starts 404-ing :)

Berdir’s picture

Should we also rename the routes (as the first patch did) and move the dynamic local actions in update_menu() to yml?

tim.plunkett’s picture

I'd rather just fix the bug, and do the YAML-ification/route rename in a dedicated issue.

@LewisNyman btw, good find and nice fix.

LewisNyman’s picture

Thanks guys, nice to find time to explore other areas. Is there anything left to do in this issue?

znerol’s picture

Issue summary:View changes
Status:Needs review» Needs work

Meanwhile the button is not shown anymore on that page. However, the behavior of the theme admin page is still not consistent:

  1. Appearance - List (default tab) is on admin/appearance (Breadcrumb: Home - Administration)
  2. Appearance - Update tab is on admin/theme/update (Breadcrumb: Home - Administration)
  3. Appearance - Settings tab is on admin/appearance/settings (Breadcrumb: Home - Administration - Appearance)
  4. Install new theme button leads to admin/theme/install (Breadcrumb: Home - Administration)

Also note the path admin/appearance/install is used for the install action link placed underneath disabled themes.

LewisNyman’s picture

Status:Needs work» Fixed

@znerol That sounds like a completely different issue, so you want to open a new one?

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.