Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
I'm not sure where this is coming from. Head to /admin to see see the button.
Comment | File | Size | Author |
---|---|---|---|
#9 | update-2102357-9-FAIL.patch | 1.69 KB | tim.plunkett |
#9 | update-2102357-9-PASS.patch | 2.4 KB | tim.plunkett |
#8 | theme-action-2102357-8.patch | 745 bytes | LewisNyman |
#3 | theme-action-2102357-3.patch | 896 bytes | LewisNyman |
install.php_2.diff.png | 48.37 KB | LewisNyman |
Comments
Comment #1
LewisNyman CreditAttribution: LewisNyman commentedComment #2
LewisNyman CreditAttribution: LewisNyman commentedThis is actually related to the update module. Looking around, I guess they sit here because there is no admin/theme path?
Comment #3
LewisNyman CreditAttribution: LewisNyman commentedI figured it out! Who said this new routing system was hard work?
Comment #4
LewisNyman CreditAttribution: LewisNyman commentedComment #6
LewisNyman CreditAttribution: LewisNyman commented#3: theme-action-2102357-3.patch queued for re-testing.
Comment #8
LewisNyman CreditAttribution: LewisNyman commentedI couldn't find any references to these paths that could be breaking the tests. I don't actually need to change the key so let's try that.
Comment #9
tim.plunkettIt doesn't help when all the test does is assert text DOESN'T show up, and then the page starts 404-ing :)
Comment #10
BerdirShould we also rename the routes (as the first patch did) and move the dynamic local actions in update_menu() to yml?
Comment #11
tim.plunkettI'd rather just fix the bug, and do the YAML-ification/route rename in a dedicated issue.
@LewisNyman btw, good find and nice fix.
Comment #12
LewisNyman CreditAttribution: LewisNyman commentedThanks guys, nice to find time to explore other areas. Is there anything left to do in this issue?
Comment #13
znerol CreditAttribution: znerol commentedMeanwhile the button is not shown anymore on that page. However, the behavior of the theme admin page is still not consistent:
admin/appearance
(Breadcrumb: Home - Administration)admin/theme/update
(Breadcrumb: Home - Administration)admin/appearance/settings
(Breadcrumb: Home - Administration - Appearance)admin/theme/install
(Breadcrumb: Home - Administration)Also note the path
admin/appearance/install
is used for theinstall
action link placed underneath disabled themes.Comment #14
LewisNyman CreditAttribution: LewisNyman commented@znerol That sounds like a completely different issue, so you want to open a new one?