Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Initial pass from pareview.sh, http://pareview.sh/pareview/httpgitdrupalorgprojectcommentnotifygit. Some errors may be spurious. It's very picky, especially about function comments. https://drupal.org/node/1354#functions is the relevant doc I think.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 2100891-code-style-5.patch | 32.83 KB | daria.a |
| #1 | 2100891-1-pareview.patch | 42.11 KB | kscheirer |
Comments
Comment #1
kscheirerLots of code style issues, but that's be expected from a module that's been around a while. This should be a good start.
Comment #2
kscheirerComment #4
gregglesI did some work on this as well and committed it. There's still more work to do so leaving this open.
Here's the output: http://pareview.sh/pareview/httpgitdrupalorgprojectcommentnotify-7x-1x
Comment #5
daria.a CreditAttribution: daria.a commentedHello Greg and Karl.
I fixed some problems in code style.
Comment #7
gregglesThanks, Daria.a. I made one small change to the docblock description of comment_notify_mark_comment_as_notified because you had split it across 2 lines which I believe is against the style standard. I shortened the sentence to help it fit on one line.
The pareview output is better http://pareview.sh/pareview/httpgitdrupalorgprojectcommentnotify-7x-1x but there are still some more things that need to be done if you have time.
Comment #8
gregglesThis seems as fixed as it's likely to get, so closing for now.
Thanks for your help, @kscheirer, @daria.a.