In #2079909: Linkit 7.x-3.x-dev does not provide a target attribute option for inserting links. I submitted a patch which added the "target" attribute for inserted links. The attribute defaults to "_self" which is technically correct, but not always what the user wants.

This patch introduces a default empty option so if no "target" attribute value is selected, no "target" attribute will be inserted.

CommentFileSizeAuthor
#2 linkit-default-target.patch679 bytestim-e
linkit-default-target.patch827 bytestim-e
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim-e’s picture

tim-e CreditAttribution: tim-e commented

Oops, sorry, bad patch, will post a fix shortly

tim-e’s picture

tim-e CreditAttribution: tim-e commented
FileSize
linkit-default-target.patch679 bytes

Here is the correct patch.

anon’s picture

anon
Primary language Swedish
Location Gothenburg
CreditAttribution: anon commented
Status: Needs review » Fixed

Thanks for patch. Commited.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

The last submitted patch, linkit-default-target.patch, failed testing.

Status: Closed (fixed) » Needs work

The last submitted patch, 2: linkit-default-target.patch, failed testing.

anon’s picture

anon
Primary language Swedish
Location Gothenburg
CreditAttribution: anon commented
Issue summary: View changes
Status: Needs work » Closed (fixed)

Closing again, the test bot change the status for some reason.