Notice: Use of undefined constant COMMENT_NODE_OPEN - assumed 'COMMENT_NODE_OPEN' in devel_generate_content_form() (line 134 of sites/default/modules/devel/devel_generate/devel_generate.module).

This happened on the latest dev.

Change request:
https://drupal.org/node/2100015

Files: 
CommentFileSizeAuthor
#1 2100305-1-comment-open-notice.patch1.73 KBjoelpittet
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2100305-1-comment-open-notice.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

joelpittet’s picture

Status:Active» Needs review
StatusFileSize
new1.73 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2100305-1-comment-open-notice.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Patch

pcambra’s picture

Title:Use of undefined constant COMMENT_NODE_OPEN» Comment settings are now a field, adapt the generation
Status:Needs review» Needs work

As comments are now fields, I'm quite sure that more stuff changed besides that variable, it'd be great to have everything in one issue.

Sort of blocked by #2100629: EntityNG is gone, adapt field generation

salvis’s picture

Assigned:joelpittet» Unassigned
Status:Needs work» Active

Sorry, joelpittet, we had a bit of confusion about what is what.

pcambra repurposed your issue, and I didn't recognize it and independently developed and pushed the same patch as #1 in #2103399: COMMENT_NODE_OPEN was renamed to COMMENT_OPEN, because that was the next item that caused #2103409: Testing currently fails....

joelpittet’s picture

thanks for getting that change in @salvis.

@pcambra if you want to change this issue to doing any other changes you are aware of, would you mind updating the issue summary as well with the tasks?

pcambra’s picture

Status:Active» Closed (duplicate)

Placed the comment fixes on #2103393: field_behaviors_widget() is removed to fix the tests and complete the comment change keep up.

What comments as field mean is that a content type might have >1 comment field, all comment variables were killed and everything is relying on instance settings.

Thanks for the initial patch @joelpittet and sorry for the scope confusion.

Marking this as dupe, but leaving the info for future reference (?)

joelpittet’s picture

Cool no worries, thanks @pcambra.