Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Updated: Comment 0
Problem/Motivation
We have a new local actions API, but most of core is not yet converted.
Proposed resolution
Convert them in order to find potential problems as well as remove the old system out of menu.inc
Remaining tasks
User interface changes
API changes
Related Issues
Comment | File | Size | Author |
---|---|---|---|
#23 | local_actions-2100073.patch | 31.04 KB | dawehner |
#18 | local_actions-2100073-18.patch | 31.08 KB | dawehner |
#18 | interdiff-18.txt | 1.63 KB | dawehner |
#17 | interdiff-17.txt | 5.81 KB | dawehner |
#17 | local_actions-2100073-17.patch | 35.26 KB | dawehner |
Comments
Comment #1
dawehnerThere we go.
Notes:
Comment #2
dawehner.
Comment #3
dawehnerThis fixes a problem on passing in the proper value of the route name.
Comment #5
dawehnerSome more work.
Comment #7
dawehnerI realized that we need to get rid of the subrequest for the dialog controller in order to allow to get the title from the route definition.
This would also happen on the NormalizeView issue so we might have to wait on that one.
Comment #9
dawehnerRemoved some of the tests which still dealt with the assumptions of local actions being in the {menu_links} table
Comment #11
dawehnerLet's rip out the rest of local actions. I personally think that the existing test is just wrong. If you request for admin/structure/content/add you expect the title of the dialog to be "Add category".
Bumping to major as this rips out the old local action system.
Comment #12
RoSk0Does this belong here?
Comment #13
dawehnerGood catch!
Comment #14
dawehner.
Comment #15
tim.plunkettThis still needs manual testing, and I will do that later tonight, unless someone swoops in before me.
Comment #16
ParisLiakos CreditAttribution: ParisLiakos commentedCode-wise this looks good.
i manual-tested though and evrything work, but one thing: the install modules action in the Extend page...all other actions are there and link where they should
Comment #17
dawehnerLet's add some tests to ensure this works.
Comment #18
dawehnerIgnore the last tests.
Comment #20
dawehner18: local_actions-2100073-18.patch queued for re-testing.
Comment #21
ParisLiakos CreditAttribution: ParisLiakos commentedcool, thanks! lets get this in then.
Comment #22
catchNo longer applies.
Comment #23
dawehnerpatch -p1 still worked.
Comment #24
catchCommitted/pushed to 8.x, thanks!
Comment #25
webchickSince this falls under "completing the routing system," would be great to target this for alpha5 (Nov 18). Tagging.
Comment #26
webchickOh, man. Sorry. The block still said RTBC. :\
Well. Success! ;)
Comment #28
ParisLiakos CreditAttribution: ParisLiakos commented23: local_actions-2100073.patch queued for re-testing.
Comment #29
ParisLiakos CreditAttribution: ParisLiakos commentedback to rtbc, since it was never committed
Comment #30
catchWas committed, but my push failed :(
Really pushed now though!
Comment #31
xjm