Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
just a req / question on the inline images..i see thats the pictures are not responive..the step to allow content creators upload inline images are not new (oh in drupal it is) so why you make not the next step and make the pictures responsive?
the pictures via the image field are responive. if drupal is going more into mobile...this step is a major requirement!
cheers
Comment | File | Size | Author |
---|---|---|---|
#3 | chrome-responsive.jpg | 74.13 KB | eule |
#3 | ff-admin-non-responsive-pic.jpg | 89.5 KB | eule |
Comments
Comment #1
nod_tag
Comment #2
BarisW CreditAttribution: BarisW commented@eule; can you provide some more information / screenshots?
As far as I can see, the images are already responsive, with or without caption.
What browser are you using?
Comment #3
eule CreditAttribution: eule commentedhey barisW i use firefox 24.0
i just wondering me ...i test also with caption here and in chrome pictures are responsive ..but not under the admin..i mean.
Comment #4
BarisW CreditAttribution: BarisW commentedClarifying issue title.
So we need to make sure that large images fit in the WYSIWYG editor as well.
Comment #5
eule CreditAttribution: eule commentedBarisW the ff-admin-non-responsive-pic.jpg is just under the admin area. its not in the "editing node"
Comment #6
BarisW CreditAttribution: BarisW commentedI'm sorry but the image really is not clear at all. It still isn't clear to me what the actual issue/bug is.
It would help if you could be a more descriptive when creating an issue. What are the steps to reproduce? On what URL do you see this happening?
Please see https://drupal.org/node/73179#issue-details for some tips on creating better issue reports.
Comment #7
eule CreditAttribution: eule commentedif we logged in we dont have responsive images
Comment #8
BarisW CreditAttribution: BarisW commentedI give up. Anyone?
Comment #9
Wim LeersFirst, this is not about editor.module.
Second, Chrome has special handling to scale images, Firefox does not. What you see in #3 in Chrome vs. Firefox is just different browser behaviors, not features or bugs in Drupal.
Third, Drupal core does not make all images automatically responsive. It only makes images in image fields when using the Picture module's formatter responsive.
Closing, because this is not actually a bug.
Comment #10
eule CreditAttribution: eule commented@Wim Leers this was a request..please read the first post. BarisW change it in #4 so i change the Status.
Comment #11
eule CreditAttribution: eule commentedComment #12
Wim LeersComment #13
webchickIMO this is an actual bug, and should be fixed. I think it might be a bug in Picture module though, that it doesn't properly deal with the image HTML that the editor is outputting, or isn't properly attaching picturefill.js to body fields' output or... something.
Comment #14
swentel CreditAttribution: swentel commentedThe picture module only really contains a formatter for image fields, so it's not that module.
And I still have no clue either what should be fixed now, I almost agree with Wim there's nothing going on here.
Comment #15
Wim Leers#13: this indeed cannot be a bug, because we've never had responsive inline images.
The only way to support this is to add a
data-picture-mapping="<picture mapping>"
attribute. And for that, we already have this issue: #2061377: [drupalImage] Optionally apply image style to images uploaded in CKEditor 5 — instead of allowing users to specify exact image dimensions (width and height) in the dialog, we should only allow users to select an image style, and if the Picture module is enabled, they should be able to select a "picture mapping".(That would also aid in removing the tedious work of making sure all images have the same dimensions. It would yield a much better control over inline images. It would be following structured content principles. It'd be much better! If we're all in favor, I'd love to work on all that in #2061377: [drupalImage] Optionally apply image style to images uploaded in CKEditor 5!)
Comment #16
swentel CreditAttribution: swentel commented#2061377: [drupalImage] Optionally apply image style to images uploaded in CKEditor 5 sounds challenging, but extremely interesting. I'm in favor :)
Comment #17
Wim LeersIt shouldn't be challenging at all!
Comment #18
attiks CreditAttribution: attiks commentedFYI: picture has support for this in the D7 version, see (for example) #1885766: WYSIWYG support
Comment #19
Wim Leers#18: Cool :) It does it in a fundamentally problematic way though in my opinion: it should use an
<img>
tag with adata-
attribute that gets transformed into a<picture>
element by a filter, so that the content is more structured & reusable. That being said: the feature itself of course makes total sense :)Comment #20
Wim LeersAlrighty, it's confirmed, I'll be working on implementing this — please follow #2061377: [drupalImage] Optionally apply image style to images uploaded in CKEditor 5 if you want to be notified of news!