just a req / question on the inline images..i see thats the pictures are not responive..the step to allow content creators upload inline images are not new (oh in drupal it is) so why you make not the next step and make the pictures responsive?

the pictures via the image field are responive. if drupal is going more into mobile...this step is a major requirement!

cheers

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nod_’s picture

Issue tags: +mobile

tag

BarisW’s picture

@eule; can you provide some more information / screenshots?

As far as I can see, the images are already responsive, with or without caption.
What browser are you using?

eule’s picture

hey barisW i use firefox 24.0
i just wondering me ...i test also with caption here and in chrome pictures are responsive ..but not under the admin..i mean.

chrome responisve pic not logged in

firefox logged in none responsive

BarisW’s picture

Title: inline image responsive? » Images do not fit within the WYSIWYG editor
Component: image system » editor.module
Category: feature » bug

Clarifying issue title.

So we need to make sure that large images fit in the WYSIWYG editor as well.

eule’s picture

BarisW the ff-admin-non-responsive-pic.jpg is just under the admin area. its not in the "editing node"

BarisW’s picture

I'm sorry but the image really is not clear at all. It still isn't clear to me what the actual issue/bug is.

It would help if you could be a more descriptive when creating an issue. What are the steps to reproduce? On what URL do you see this happening?

Please see https://drupal.org/node/73179#issue-details for some tips on creating better issue reports.

eule’s picture

if we logged in we dont have responsive images

BarisW’s picture

I give up. Anyone?

Wim Leers’s picture

Assigned: Unassigned » Wim Leers
Category: bug » support
Status: Active » Fixed

First, this is not about editor.module.

Second, Chrome has special handling to scale images, Firefox does not. What you see in #3 in Chrome vs. Firefox is just different browser behaviors, not features or bugs in Drupal.

Third, Drupal core does not make all images automatically responsive. It only makes images in image fields when using the Picture module's formatter responsive.

Closing, because this is not actually a bug.

eule’s picture

Assigned: Wim Leers » Unassigned
Category: support » feature
Status: Fixed » Active

@Wim Leers this was a request..please read the first post. BarisW change it in #4 so i change the Status.

eule’s picture

Title: Images do not fit within the WYSIWYG editor » inline image responsive?
Wim Leers’s picture

Title: inline image responsive? » Automatically make images in body field responsive?
webchick’s picture

Title: Automatically make images in body field responsive? » Images in body field are not responsive
Component: editor.module » picture.module
Category: feature » bug

IMO this is an actual bug, and should be fixed. I think it might be a bug in Picture module though, that it doesn't properly deal with the image HTML that the editor is outputting, or isn't properly attaching picturefill.js to body fields' output or... something.

swentel’s picture

Component: picture.module » editor.module
Category: bug » feature

The picture module only really contains a formatter for image fields, so it's not that module.

And I still have no clue either what should be fixed now, I almost agree with Wim there's nothing going on here.

Wim Leers’s picture

#13: this indeed cannot be a bug, because we've never had responsive inline images.

The only way to support this is to add a data-picture-mapping="<picture mapping>" attribute. And for that, we already have this issue: #2061377: [drupalImage] Optionally apply image style to images uploaded in CKEditor 5 — instead of allowing users to specify exact image dimensions (width and height) in the dialog, we should only allow users to select an image style, and if the Picture module is enabled, they should be able to select a "picture mapping".

(That would also aid in removing the tedious work of making sure all images have the same dimensions. It would yield a much better control over inline images. It would be following structured content principles. It'd be much better! If we're all in favor, I'd love to work on all that in #2061377: [drupalImage] Optionally apply image style to images uploaded in CKEditor 5!)

swentel’s picture

#2061377: [drupalImage] Optionally apply image style to images uploaded in CKEditor 5 sounds challenging, but extremely interesting. I'm in favor :)

Wim Leers’s picture

It shouldn't be challenging at all!

attiks’s picture

FYI: picture has support for this in the D7 version, see (for example) #1885766: WYSIWYG support

Wim Leers’s picture

#18: Cool :) It does it in a fundamentally problematic way though in my opinion: it should use an <img> tag with a data- attribute that gets transformed into a <picture> element by a filter, so that the content is more structured & reusable. That being said: the feature itself of course makes total sense :)

Wim Leers’s picture

Status: Active » Closed (duplicate)

Alrighty, it's confirmed, I'll be working on implementing this — please follow #2061377: [drupalImage] Optionally apply image style to images uploaded in CKEditor 5 if you want to be notified of news!