I can't see 'field_ui' a hard dependency for the asset module.

I can see however that two hooks implements field_ui definition, but these are a pre-requisite for asset module to work correctly or is more a tool to help an administrator or a programmer to configure its field instance? Because in this case, when exporting settings in features or by code, on production website, the field_ui module would not be required at all.

CommentFileSizeAuthor
#1 asset-disable-dependency-field-ui-2099491-1.patch271 bytessergeypavlenko
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sergeypavlenko’s picture

sergeypavlenko CreditAttribution: sergeypavlenko commented
Issue summary: View changes
FileSize
asset-disable-dependency-field-ui-2099491-1.patch271 bytes

Hi

I think dependency "field_ui" is not required and we can remove it from .info file. On my project need disable "field_ui" for site optimization. In code module asset, have only two function related with "field_ui":

asset_form_field_ui_display_overview_form_alter();
assets_field_ui_display_overview_form_submit();

We can remove dependency and asset should work fine!

sergeypavlenko’s picture

sergeypavlenko CreditAttribution: sergeypavlenko commented
Status: Active » Needs review
Sylvain Lecoy’s picture

Sylvain Lecoy CreditAttribution: Sylvain Lecoy commented
Status: Needs review » Reviewed & tested by the community

Works for me

IRuslan’s picture

IRuslan CreditAttribution: IRuslan as a volunteer and at DrupalJedi commented

Nice catch, pushed to dev.

IRuslan’s picture

IRuslan CreditAttribution: IRuslan as a volunteer and at DrupalJedi commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.