If you click "unpublish" on a comment, it will remove the unpublish links from all of the other comments. if you reload the page they come back, and the comment is unpublished, so not a big deal, but definitely a regression.

Deployment

  1. Enable fasttoggle_comment fasttoggle_user fasttoggle_node
  2. Configure at /admin/config/system/fasttoggle
  3. Set permissions at /admin/people/permissions
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jthorson’s picture

Title: Quicklinks on all issue comments disappear once clicked on one » Ajax Quicklinks on all issue comments disappear once clicked on one
Status: Active » Needs review
Issue tags: +drupal.org D7

Confirmed (via dev site).

The other links (edit, delete, report spam) all take you to a new page load, so I think the 'unpublish' is the only one this is relevant for.

tvn’s picture

Title: Ajax Quicklinks on all issue comments disappear once clicked on one » 'Unpublish' quicklinks on all issue comments disappear once clicked on one
Project: [Archive] Drupal.org D7 upgrade QA » Drupal.org customizations
Version: » 7.x-3.x-dev
Component: Code » User interface
Status: Needs review » Active
Issue tags: -drupal.org D7 +Drupal.org 7.1
dww’s picture

Aren't these links from fasttoggle? Shouldn't we move this issue there, or do we have some reason to believe this is a d.o-specific bug?

Thanks,
-Derek

mgifford’s picture

Project: Drupal.org customizations » Fasttoggle
Version: 7.x-3.x-dev » 7.x-1.x-dev
Issue summary: View changes

Hopefully we can verify if this is an issue with d.o or fasttoggle here.

Nigel Cunningham’s picture

Sorry for my slowness in responding. I'll take a look.

Nigel Cunningham’s picture

The 7.x-1.x-dev branch does work, but the active classis is left on the link afterwards; I'll look at that further when I next get a chance.

mgifford’s picture

Thanks! Any thoughts on putting out a stable release with this functionality in it?

Nigel Cunningham’s picture

Yes, I just want to work on the fields support more first so there are no regressions.

Nigel Cunningham’s picture

I'm unable to reproduce the behaviour described when using the 7.x dev branch.

The active class is no longer left on fasttoggled links, by the way.

mgifford’s picture

What's the ETA on the next stable release?

Nigel Cunningham’s picture

A week or two.

I want to work through some of the integration requests and check that the reworked API is flexible enough to meet all their requirements, then I'll do the release.

m1r1k’s picture

Assigned: Unassigned » m1r1k
m1r1k’s picture

Here is a patch for 7.x-1.2 branch :

m1r1k’s picture

Status: Active » Needs review
tvn’s picture

Issue tags: -Drupal.org 7.1 +Drupal.org 7.1. d.o szeged sprint
tvn’s picture

Issue tags: -Drupal.org 7.1. d.o szeged sprint +Drupal.org 7.1, +drupal.org szeged sprint
Nigel Cunningham’s picture

Ah... so it's a really old version. That's why I can't reproduce it.

I just want to finish the fields integration, then I'll roll a new release.

drumm’s picture

Title: 'Unpublish' quicklinks on all issue comments disappear once clicked on one » Upgrade to fasttoggle 'Unpublish' quicklinks on all issue comments disappear once clicked on one
Project: Fasttoggle » Drupal.org customizations
Version: 7.x-1.x-dev » 7.x-3.x-dev
Status: Needs review » Postponed

Ok, we'll upgrade to 7.x-1.3 when it is released.

drumm’s picture

Title: Upgrade to fasttoggle 'Unpublish' quicklinks on all issue comments disappear once clicked on one » Upgrade to fasttoggle 7.x-1.3 - 'Unpublish' quicklinks on all issue comments disappear once clicked on one
tvn’s picture

Status: Postponed » Needs work

Fasttoggle 7.x-1.3 is out!

Nigel Cunningham’s picture

Please hold off for a bit. I didn't pay enough attention to the upgrade from 7.x-1.2 and am just finishing off some fixes. Hope to have 7.x-1.4 out within an hour if I can.

Nigel Cunningham’s picture

Status: Needs work » Needs review
drumm’s picture

Status: Needs review » Fixed

Now deployed on Drupal.org.

drumm’s picture

Title: Upgrade to fasttoggle 7.x-1.3 - 'Unpublish' quicklinks on all issue comments disappear once clicked on one » Upgrade to fasttoggle 7.x-1.5 - 'Unpublish' quicklinks on all issue comments disappear once clicked on one
Status: Fixed » Postponed

We needed to roll back to 1.2. We'll try 1.5 when released.

drumm’s picture

Status: Postponed » Needs review
Issue tags: +needs drupal.org deployment
drumm’s picture

Status: Needs review » Fixed

I've merged this to Drupal.org staging sites - git7site.devdrupal.org, staging.devdrupal.org.

I plan to deploy this tomorrow.

drumm’s picture

Issue summary: View changes
drumm’s picture

Issue tags: -needs drupal.org deployment

Now deployed again.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.