Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
If you click "unpublish" on a comment, it will remove the unpublish links from all of the other comments. if you reload the page they come back, and the comment is unpublished, so not a big deal, but definitely a regression.
Deployment
- Enable fasttoggle_comment fasttoggle_user fasttoggle_node
- Configure at /admin/config/system/fasttoggle
- Set permissions at /admin/people/permissions
Comment | File | Size | Author |
---|---|---|---|
#13 | fasttoggle-unpublish-link-remove-all-other-unpublish-links-2098117-13.patch | 959 bytes | m1r1k |
Comments
Comment #1
jthorson CreditAttribution: jthorson commentedConfirmed (via dev site).
The other links (edit, delete, report spam) all take you to a new page load, so I think the 'unpublish' is the only one this is relevant for.
Comment #2
tvn CreditAttribution: tvn commentedComment #3
dwwAren't these links from fasttoggle? Shouldn't we move this issue there, or do we have some reason to believe this is a d.o-specific bug?
Thanks,
-Derek
Comment #4
mgiffordHopefully we can verify if this is an issue with d.o or fasttoggle here.
Comment #5
Nigel CunninghamSorry for my slowness in responding. I'll take a look.
Comment #6
Nigel CunninghamThe 7.x-1.x-dev branch does work, but the active classis is left on the link afterwards; I'll look at that further when I next get a chance.
Comment #7
mgiffordThanks! Any thoughts on putting out a stable release with this functionality in it?
Comment #8
Nigel CunninghamYes, I just want to work on the fields support more first so there are no regressions.
Comment #9
Nigel CunninghamI'm unable to reproduce the behaviour described when using the 7.x dev branch.
The active class is no longer left on fasttoggled links, by the way.
Comment #10
mgiffordWhat's the ETA on the next stable release?
Comment #11
Nigel CunninghamA week or two.
I want to work through some of the integration requests and check that the reworked API is flexible enough to meet all their requirements, then I'll do the release.
Comment #12
m1r1k CreditAttribution: m1r1k commentedComment #13
m1r1k CreditAttribution: m1r1k commentedHere is a patch for 7.x-1.2 branch :
Comment #14
m1r1k CreditAttribution: m1r1k commentedComment #15
tvn CreditAttribution: tvn commentedComment #16
tvn CreditAttribution: tvn commentedComment #17
Nigel CunninghamAh... so it's a really old version. That's why I can't reproduce it.
I just want to finish the fields integration, then I'll roll a new release.
Comment #18
drummOk, we'll upgrade to 7.x-1.3 when it is released.
Comment #19
drummComment #20
tvn CreditAttribution: tvn commentedFasttoggle 7.x-1.3 is out!
Comment #21
Nigel CunninghamPlease hold off for a bit. I didn't pay enough attention to the upgrade from 7.x-1.2 and am just finishing off some fixes. Hope to have 7.x-1.4 out within an hour if I can.
Comment #22
Nigel CunninghamComment #23
drummNow deployed on Drupal.org.
Comment #24
drummWe needed to roll back to 1.2. We'll try 1.5 when released.
Comment #25
drummComment #26
drummI've merged this to Drupal.org staging sites - git7site.devdrupal.org, staging.devdrupal.org.
I plan to deploy this tomorrow.
Comment #27
drummComment #28
drummNow deployed again.