Enhanced control over the Headline tag of any Block.

Block Headline allows users to change block headline tag to any block through
the block's configuration interface. This implementation is based on an
alteration of the Core block database table to leverage the Core Block API
functions, objects and structure.

Project page: https://drupal.org/sandbox/szpetya06/2096839

Git clone: git clone http://git.drupal.org/sandbox/szpetya06/2096839.git block_headline

How to test:
1. Enable the module
2. To changed the block headline, simply visit that block's configuration page at
Administration > Structure > Blocks

Comments

PA robot’s picture

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Enxebre’s picture

Hello,
I´ve installed and tested the module. It works fine and I wasn´t able to find another modules with similar functionality. Just a comment, probably creating a new related table seems less "dangerous" than modify a core table.
The module looks fine.

Regards.

forestmars’s picture

Your Git clone repo link should be:

git clone http://git.drupal.org/sandbox/szpetya/2096839.git

(not: git clone --branch 7.x-1.x szpetya06@git.drupal.org:sandbox/szpetya06/2096839.git)

thebruce’s picture

The code for this module looks fine. The functional test I did went without a hitch - providing the new functionality from your module. The install and un-installation added and removed the field from the table respectively.

Looks good. Cheers!

batdesign’s picture

Manual Review
The module worked on a fresh Drupal install.

I only noticed on small coding issue.

In block.tpl.php line 51, you forgot the ';' after print $block->subject

Other then that, it looks good.

gaborpeter’s picture

I've downloaded the module and works fine for me.

Minimal fine-tuning idea:
Nice to see that you are familiar with the _perm hook, although a separate permission for this setting might not be necessary, you could simply use the block module's "administer blocks" permission.

Good job!

drupalfan79’s picture

Hi, t() function is not needed in line 47, block_headline.module:

      '#options' => array(
        'H1' => t('H1'),
        'H2' => t('H2'),
        'H3' => t('H3'),
        'H4' => t('H4'),
        'H5' => t('H5'),
        'H6' => t('H6'),
      ),
t14’s picture

Hi

Your readme.txt file could do with more information, the same goes for your project page.
Here is a good example of a readme.txt file
http://drupalcode.org/project/admin_menu.git/blob/refs/heads/7.x-3.x:/RE...

I agree with comment #2 it would be better to create a new related table instead of modifying a core table.

Thanks
T

Pontus Rosin’s picture

I have tried the plugin on a fresh installation and it works. I think it would benefit with some description of user cases when it would be necessary. But its working.

AjitS’s picture

Status:Needs review» Needs work

If you come up with blockers, the status needs to be changed to needs work.

AjitS’s picture

Issue summary:View changes

Git clone edited

PA robot’s picture

Issue summary:View changes
Status:Needs work» Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

szpetya06’s picture

Hello

I fixed some issue.
#2: I created a new database for this module.
#5: semicolon is added.
#6: I'm using the "administer blocks" permission.
#7: t() is removed

Thx for the issues

Regards
P

szpetya06’s picture

Status:Closed (won't fix)» Active
AjitS’s picture

Welcome back! Don't forget to change the issue status to "Needs Review" after addressing all the issues that were pointed out.

szpetya06’s picture

Issue summary:View changes
Status:Active» Needs review
PA robot’s picture

Status:Needs review» Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxszpetya062096839git

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

Status:Needs work» Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.