This is the code in user.module:

<?php
function user_view_multiple($accounts, $view_mode = 'full', $langcode = NULL) {
  return entity_view($accounts, $view_mode, $langcode);
}
?>

it muse use entity_view_multiple() instead of entity_view().
Files: 
CommentFileSizeAuthor
#1 2097437-1-user-view-multiple.patch546 bytesJelle_S
PASSED: [[SimpleTest]]: [MySQL] 58,848 pass(es). View

Comments

Jelle_S’s picture

Status:Active» Needs review
StatusFileSize
new546 bytes
PASSED: [[SimpleTest]]: [MySQL] 58,848 pass(es). View

Patch

Berdir’s picture

Thanks. I'm not sure if we even want to keep this, probably not? Did we remov other view methods when converting to use routes?

Jelle_S’s picture

I did a search through drupal core (just netbeans right-click -> find, no fancy grep ;-) ) and did not find any usages of user_view_multiple. We might just delete it in favour of entity_view_multiple. But then again, there's also node_view_multiple (which is used in node_show and taxonomy_term_page.

Berdir’s picture

Yes, and node_show() and taxonomy_term_page() will go away when they are property converted to controller classes, which don't need any wrapper functions anymore, there's a default controller to display an entity.

Jelle_S’s picture

Ah, I see...
Do we need to create separate issues for removing *_view_multiple() functions, and add them to the list in #1971384: [META] Convert page callbacks to controllers?

[EDIT]
Come to think of it, *_view functions should be removed as well then?

catch’s picture

Status:Needs review» Reviewed & tested by the community

I think we should remove this, but until then I'm happy to commit this as is.

catch’s picture

Status:Reviewed & tested by the community» Fixed

Committed/pushed to 8.x, thanks! Just a one-liner to fix already dead code so ignoring my usual 24+ hour time from RTBC.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.