Problem/Motivation

When using a file widget (uploading a file) after selecting the progress bar as progress indicator in the widget settings of a file field, an AJAX error is triggered (basically a 404 Not Found) because the argument to \Drupal\file\Controller\FileWidgetAjaxController::progress was skipped in file.routing.yml

Proposed resolution

Fix file.routing.yml by adding the argument to the path

Remaining tasks

Apply and commit patch from #1

User interface changes

None.

API changes

None.

None.
(Discovered issue while I was working on #1751382: Selectors clean-up: file module)

CommentFileSizeAuthor
#8 Screenshot from 2013-11-27 12:26:56.png12.66 KBJelle_S
#3 file-uploadprogress-before.png9.99 KBidebr
#1 2097147-1-file-widget-progress-bar.patch456 bytesJelle_S
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Jelle_S’s picture

Jelle_S
Primary language Dutch
Location Antwerp, Belgium
CreditAttribution: Jelle_S commented
Status: Active » Needs review
FileSize
2097147-1-file-widget-progress-bar.patch456 bytes

And the corresponding patch:

Jelle_S’s picture

Jelle_S
Primary language Dutch
Location Antwerp, Belgium
CreditAttribution: Jelle_S commented
Issue summary: View changes

Updated issue summary.

johnmcc’s picture

johnmcc CreditAttribution: johnmcc commented

I was able to replicate the issue and the patch in #1 resolved it.

johnmcc’s picture

johnmcc CreditAttribution: johnmcc commented
Issue summary: View changes

Updated issue summary.

idebr’s picture

idebr CreditAttribution: idebr commented
Assigned: Jelle_S » Unassigned
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
FileSize
file-uploadprogress-before.png9.99 KB

I can confirm the bug report, see file-uploadprogress-before.png

Patch in #1 resolves this issue

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

1: 2097147-1-file-widget-progress-bar.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: 2097147-1-file-widget-progress-bar.patch, failed testing.

Jelle_S’s picture

Jelle_S
Primary language Dutch
Location Antwerp, Belgium
CreditAttribution: Jelle_S commented

1: 2097147-1-file-widget-progress-bar.patch queued for re-testing.

The last submitted patch, 1: 2097147-1-file-widget-progress-bar.patch, failed testing.

Jelle_S’s picture

Jelle_S
Primary language Dutch
Location Antwerp, Belgium
CreditAttribution: Jelle_S commented
FileSize
Screenshot from 2013-11-27 12:26:56.png12.66 KB

I'm guessing this is testbot acting up? :/

Only one fail (screenshot attached). Doesn't seem to have to do anything with the progressbar functionality...

Jelle_S’s picture

Jelle_S
Primary language Dutch
Location Antwerp, Belgium
CreditAttribution: Jelle_S commented

1: 2097147-1-file-widget-progress-bar.patch queued for re-testing.

Jelle_S’s picture

Jelle_S
Primary language Dutch
Location Antwerp, Belgium
CreditAttribution: Jelle_S commented
Status: Needs work » Needs review

There we go. Good boy, testbot, good boy! Have a cookie!

slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented

Looks ok. Could we that test coverage for that?

slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented
Status: Needs review » Needs work
Jelle_S’s picture

Jelle_S
Primary language Dutch
Location Antwerp, Belgium
CreditAttribution: Jelle_S commented

Not sure what to add test coverage for here? To check if the argument in the yaml file is set?

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

AltaGrade’s picture

AltaGrade CreditAttribution: AltaGrade commented
Status: Needs work » Closed (duplicate)

Even-though #2587755: AJAX error when using progress bar on file field widget was created later than this thread, it has an already committed solution for the same problem.