We should remove '@media @normal, @wide' from body styling because we use navbar that is fixed on top as default. (it should always have padding-top)

@media @normal, @wide {
    padding-top: 60px;
 }
CommentFileSizeAuthor
bootstrap-fix-missing-padding-body.patch463 byteskslonka
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

diegohermes’s picture

diegohermes CreditAttribution: diegohermes commented
Assigned: Unassigned » diegohermes
markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell commented
Assigned: diegohermes » markhalliwell
Status: Needs review » Needs work

Actually I would like to take a look at this. There's several components involved for both anonymous and authenticated (admin_menu, core toolbar) and of course the other breakpoints should be looked at as well.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell commented
Title: Missing padding to <body> » Fix <body> paddings for with fixed navbar/admin toolbars
markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell commented

Marked #2110565: Body has top padding of 129px a dup of this issue.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell commented
Assigned: markhalliwell » Unassigned

I don't think I'll be able to get to this at the moment.

@valkum or @el7cosmos, could you take a look at this instead. If one or the other gets to it first, assign to yourself please so the other knows you're working on it. Thanks

Also, keep in mind this should now also include fixes for the different navbar positions (theme-settings).

valkum’s picture

valkum CreditAttribution: valkum commented
Assigned: Unassigned » valkum

See my latest patch #2107041: .navbar-fixed-top obscures anchors will reroll this patch later this day.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell commented
Assigned: valkum » Unassigned
Status: Needs work » Closed (duplicate)

Ah, well closing this issue as a dup of that one (since it has a more extensive patch already).

knalstaaf’s picture

knalstaaf CreditAttribution: knalstaaf commented
Issue summary: View changes

Not my intention to exhume this topic but I couldn't find a solution in the topic that's being referred to.

In version 7.x-3.0 I had to add the following code to my CSS to make it look alright for the admin / logged in as well as anonymous users:

body.navbar-is-fixed-top {
    padding-top: 94px !important;
}

Just in case someone else runs into this. I'm aware this topic is about the dev-version, but it actually describes what's going on better than the others: the page looks ok for logged in users, but not for anonymous users (too little padding-top for the body), strangely enough. Anyway, it's fixed with the code above.