Updated: Comment #5

Commit/Message

Issue #2095917 by penyaskito, e0ipso: Move Date format localization to language module.

Problem/Motivation

Move the Date format localization feature to the locale (Interface Translation) module.
META: #2052193: [META] Date format localisation is a huge mess, conflicts, does not work, regressed.

Proposed resolution

Move this functionality to language module, so we can adapt date formats to the different languages.

Remaining tasks

- Debate about if the right place should be locale or language.
- Patch review needed.

User interface changes

None.

API changes

None.

(A list of related issues.)

CommentFileSizeAuthor
#4 date-format-locale-2095917-1.patch8.31 KBpenyaskito
#4 date-format-locale-2095917.1-2.txt7.25 KBpenyaskito
#4 date-format-locale-2095917-2.patch8.66 KBpenyaskito
#3 date-format-locale-2095917.1-2.txt7.25 KBpenyaskito
#2 date-format-locale-2095917.1-2.txt7.25 KBpenyaskito
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
Assigned: Unassigned » penyaskito
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
Status: Active » Needs review
FileSize
date-format-locale-2095917.1-2.txt7.25 KB

Moved the date format localize menu callbacks and forms to locale module.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
Title: Move Date format localization to locale module » Move Date format localization to language module
FileSize
date-format-locale-2095917.1-2.txt7.25 KB

While doing the patch before, I thought that maybe the right place is the language module.
Pairing in Prague with e0ipso, so credit to him too.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
FileSize
date-format-locale-2095917-2.patch8.66 KB
date-format-locale-2095917.1-2.txt7.25 KB
date-format-locale-2095917-1.patch8.31 KB

The previous patch is only interdiff, sorry. Uploading full patches again.

date-format-locale-2095917-1.patch moves functionality to locale.
date-format-locale-2095917-2.patch moves functionality to language.

Status: Needs review » Needs work

The last submitted patch, date-format-locale-2095917-2.patch, failed testing.

Jose Reyero’s picture

Jose Reyero CreditAttribution: Jose Reyero commented

I think moving it to language module doesn't make any sense since this is a 'localization' feature....

Anyway, there was this one in case it is any help, #2059835: Implement translation interface for date formats as part of locale UI

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
Status: Needs work » Closed (duplicate)

Closing as duplicated then, and updating META.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Issue tags: -sprint
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

Very sticky tag.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Issue summary: View changes

Issue template.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
Assigned: penyaskito » Unassigned
Issue summary: View changes