API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Extension...

It would seem that invoking a hook now needs the params for the hook to be a single array, the same as for theme() calls.

The docs for this interface method still use the old format.

The change record here https://drupal.org/node/1894902 also needs to properly mention this change.

#4 drupal8.documentation.2095219-4.patch.patch545 byteshrmoller
PASSED: [[SimpleTest]]: [MySQL] 58,877 pass(es).
[ View ]


jhodgdon’s picture

Issue tags:+Novice

I don't think the change notice needs to mention this actually -- it's implied by the table of changes, and presumably if the function call is different, people will go to api.d.o and read the docs. But yes, the method docs need an update. Seems like a good novice project.

hrmoller’s picture

I'm not sure I understand what this issue is abut. Is it just the docs that needs an update or should the paramters of ::invokeAll be changed?
I'm a novice here so be gentle:)

joachim’s picture

This is a docs issue, so it's just the function docs that need changing.

> I don't think the change notice needs to mention this actually -- it's implied by the table of changes

It's easily missed!

hrmoller’s picture

new545 bytes
PASSED: [[SimpleTest]]: [MySQL] 58,877 pass(es).
[ View ]

So would this be sufficient?

hrmoller’s picture

Assigned:Unassigned» hrmoller
Status:Active» Needs review

Status:Needs review» Needs work
Issue tags:-Novice

The last submitted patch, drupal8.documentation.2095219-4.patch.patch, failed testing.

hrmoller’s picture

Status:Needs work» Needs review
Issue tags:+Novice
dawehner’s picture

Status:Needs review» Reviewed & tested by the community


jhodgdon’s picture

Indeed, that is what we need. Thanks!

catch’s picture

Category:bug» task
Priority:Critical» Major
Status:Reviewed & tested by the community» Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.