The bartik.theme file still references html.tpl.php in the comment for
function bartik_preprocess_html(&$variables) {

Should be html.html.twig.

#1 bartik-theme-html-html-twig-comment-correction-2095109-1.patch391 byteschris_hall_hu_cheng
PASSED: [[SimpleTest]]: [MySQL] 58,404 pass(es). View
Members fund testing for the Drupal project. Drupal Association Learn more


chris_hall_hu_cheng’s picture

Status: Active » Needs review
391 bytes
PASSED: [[SimpleTest]]: [MySQL] 58,404 pass(es). View

Corrected comment in attached patch.

mradcliffe’s picture

Issue tags: +documentation

Patch does what it intends to do and applies.

This issue is a follow-up to #1033116: Rename template.php to THEMENAME.theme to eliminate ambiguity around "the template file" vs. "template files" where that patch did not update all of the doc blocks.

There are 2 instances of this in the seven theme, and seven also references tpl.php in a comment within a function. Should this issue could be expanded in scope and changed to the documentation component?

  • seven_preprocess_maintenance_page() comments mention page.tpl.php and html.tpl.php.
  • seven_preprocess_html() doc block mentions html.tpl.php
  • seven_preprocess_page() doc block mentions page.tpl.php
chris_hall_hu_cheng’s picture

Thanks for adding the tag, I will know to do that next time.

What is the fastest option? I can raise another issue and happy to submit an issue and patch for the documentation in Seven theme tomorrow.

Apologies for not looking further, I was focused on Bartik as I was sub-themeing it for my blog.

chris_hall_hu_cheng’s picture

I did it I raised and issue and patch for the references to similar problems in Seven made in #2
#2098399: Seven commenting has a number of references to .tpl.php files

LinL’s picture

This looks good, but there is already an issue to make all of these changes in one go: #2049207: [Follow up] Replace .tpl.php with .html.twig in documentation, so this one can be closed as a duplicate.

chris_hall_hu_cheng’s picture

So I just wasted my time, also with the one for Seven, did try searching but came up with nothing (my search was obviously bad)
and the comment-er in #2 obviously wasn't aware of #2049207: [Follow up] Replace .tpl.php with .html.twig in documentation either.

Where do I start?? I don't have time to hang around in IRC for ages, ask loads of questions just to find out how to make basic contributions.

The issue you refer to is months old has over 70 comments and still isn't resolved, meanwhile allowing ignorant newcomers like me to waste time.

Contrib land is looking much more fun and agile right now? or am I missing something.

Not meaning to be negative, partly a rhetorical question but would be grateful for some pointers or compelling reason to get involve in core for Drupal 8 at all at any level if anybody has the time.

mradcliffe’s picture

Status: Needs review » Closed (duplicate)

I tried searching for "tpl" in the issue queue and I didn't see it when I skimmed the list.

I have submitted duplicate issues before and it is not a problem, chris_hall_hu_cheng. I am often in the same situation - less time to hang around in IRC. If you're interested in core development in general, then the best place to get situated is probably, which provides tasks that can be accomplished.

The best thing to do now is to switch over to that issue and help review the patches.

Side Note: Contrib is much easier because there is less noise.

chris_hall_hu_cheng’s picture

No problem, I have commit rights on the contrib. blog module for D8 so have plenty to keep me busy getting that fixed up for D8 and then turning it into a proper blog module ;)