Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Navigation looks weird, need to add padding to logo and remove pull right from login.
Comments
Comment #1
kslonka CreditAttribution: kslonka commentedscreenshot before after
Comment #2
valkum CreditAttribution: valkum commentedapprove.
patch works.
Comment #3
markhalliwellNow that Bootstrap is technically mobile first, we should reverse this so it only applies a float on tablet and above.
Comment #4
markhalliwellAlso, go ahead and take out the logo modifications. We have #2094411: Create new logo which will probably alter this anyway.
Comment #5
valkum CreditAttribution: valkum commentedShould be this way, or am i wrong?
Comment #6
markhalliwellThat looks right, yes... but I'd like someone to review this manually.
Comment #7
markhalliwellIn reality, this should probably just be:
But the variables need to be updated to be a min-width, not set sizes.
Comment #9
valkum CreditAttribution: valkum commentedSo the following changes are in this patch.
* fix navbar element floating on mobile displays
* reworked all media queries to be mobile first.
Comment #10
valkum CreditAttribution: valkum commentedComment #11
markhalliwellSorry to do this, but I was in the middle of #2098175: Clean up files and now the structure has completely changed (to be easier for maintaining). Please re-roll your patch against the latest HEAD. Also, be sure to read the documentation in template.php to understand what has changed. Thanks!
Comment #12
valkum CreditAttribution: valkum commentedThats a lot of new files ^^
But this patch should be fine. Only the menu function moved to theme/menu/...
No big deal.
Comment #13
wundo CreditAttribution: wundo commentedwarning: 1 line adds whitespace errors.
Fixed and Committed!
Comment #14
wundo CreditAttribution: wundo commentedOhh Valkum, I'm sorry, I forgot to change the commit author.
Comment #15
markhalliwellI just fixed a few things, but gave @valkum credit since there was a mishap :)
Committed 29dfb51 to 7.x-3.x.
Comment #16
valkum CreditAttribution: valkum commentedOhh i missed a MQ. sry. @wundo, no problem.
Comment #17
markhalliwellComment #19
MMTLukas CreditAttribution: MMTLukas commented12: bootstrap-add-navbar-fix-and-mobile-first-changes-for-override-less-2094991-12.patch queued for re-testing.
Comment #21
markhalliwellDon't retest patches that have already been committed to code (they will always fail).
Comment #22
markhalliwellOops, wrong status.