Part of #2089331: [meta] Replace calls to check_plain() with Drupal\Component\Utility\String::checkPlain()

CommentFileSizeAuthor
#7 interdiff-2093167-3-6.txt509 bytesjohnnydarkko
#6 2093167-depricated-check_plain-6.patch547 bytesjohnnydarkko
#3 2093167-depricated-check_plain-3.patch547 bytesVibjerg
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT commented
Assigned: Unassigned » JeroenT

Working on it at Drupalcon Prague sprint

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT commented
Assigned: JeroenT » Unassigned
Vibjerg’s picture

Vibjerg CreditAttribution: Vibjerg commented
Status: Active » Needs review
FileSize
2093167-depricated-check_plain-3.patch547 bytes

I interpreted this issue as just writing the comment for deprecating check_plain. The actual substitution of calls seems to be spread out onto tasks under #2089331: [meta] Replace calls to check_plain() with Drupal\Component\Utility\String::checkPlain()

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
Status: Needs review » Needs work

Thanks @Vibjerg, looks good. The only issue is the comment is a few characters too long, it needs to be wrapped at 80 characters per http://drupal.org/node/1354#drupal.

johnnydarkko’s picture

johnnydarkko CreditAttribution: johnnydarkko commented
Assigned: Unassigned » johnnydarkko

Working on it during drupal mentoring.

johnnydarkko’s picture

johnnydarkko CreditAttribution: johnnydarkko commented
Assigned: johnnydarkko » Unassigned
Status: Needs work » Needs review
FileSize
2093167-depricated-check_plain-6.patch547 bytes

Re-rolled Vibjerg's patch from #3 and added a line-break per Drupal Standards.

johnnydarkko’s picture

johnnydarkko CreditAttribution: johnnydarkko commented
FileSize
interdiff-2093167-3-6.txt509 bytes

Sorry, forgot to attach an interdiff in #6.

japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry commented
Status: Needs review » Reviewed & tested by the community

Patch in #6 looks good to me

johnnydarkko’s picture

johnnydarkko CreditAttribution: johnnydarkko commented
Assigned: Unassigned » johnnydarkko
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work
johnnydarkko’s picture

johnnydarkko CreditAttribution: johnnydarkko commented
Assigned: johnnydarkko » Unassigned
Status: Needs work » Reviewed & tested by the community
Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

6: 2093167-depricated-check_plain-6.patch queued for re-testing.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented

Committed/pushed to 8.x, thanks!

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.