I'm using drupal multisite and I've run into an issue where dependencies or field groups are added to a shared module during a drush fu and it ends up breaking the other site because it will depend on a module that only one site can access (the other one defines the necessary requirement in a different module) or it makes the module start having conflicts by adding field groups that are already defined somewhere else.

I have put the problem items into features_exclude in my info file to avoid this, however this is not checked by field_group when it adds dependencies and related field groups.

I don't think a dependency or a feature should ever get automatically added to a module if it is in that modules feature_exclude list.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jmuzz’s picture

Version: 7.x-2.x-dev » 7.x-1.x-dev
Status: Active » Needs review
FileSize
2.18 KB

The patch adds the necessary checks to avoid addings things to a feature that are in its features_exclude

nils.destoop’s picture

FileSize
42.14 KB

What version of features are you using? When i test this on the 2.x branch of features, the groups that are in the features_exclude list, are correctly beïng checked out.
See screenshot (2 groups are not in the exclude list, the others are).

jmuzz’s picture

Status: Needs review » Closed (won't fix)

I had been using 2.0-rc3, but I tried with the latest repository and I got the same results, though after seeing your screenshot I looked at the recreate feature dialog and it seems to deselect the correct items. It looks like the excludes are only being ignored when I try to do it with drush...

Anyways since I brought this up I found similar problems with other modules so I'm starting to think it might be a problem with the features module, I'll try and figure out what's going on and maybe try over there.