Updated: Comment #2

Problem/Motivation

libraries_parse_dependency() duplicates \Drupal\Core\Extension\ModuleHandler::parseDependency(). It was initially introduced as the latter was protected but that recently changed in #2068797: ModuleHandler::parseDependency should be public. We can now re-use that function.

Proposed resolution

Re-use ModuleHandler::parseDependency() and remove libraries_parse_dependency()

Remaining tasks

Commit patch. Since this is pretty trivial I will commit this without further reviews.

API changes

libraries_parse_dependency() is removed. Since that was only introduced as a clutch ~2 weeks ago I don't think anyone is affected by that.

CommentFileSizeAuthor
kill-libraries-parse-dependency.patch3.53 KBtstoeckler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, kill-libraries-parse-dependency.patch, failed testing.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Category: task » bug
Status: Needs work » Reviewed & tested by the community

Due to https://drupal.org/node/2082661 this now breaks HEAD after #2090379: 8.x-3.x broken after 'pattern' -> 'path' rename in *.routing.yml. Will commit this now.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Reviewed & tested by the community » Fixed

http://drupalcode.org/project/libraries.git/commit/c9f38da6b564bac81dc02...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Updated issue summary per comment #2.