This is Drupal distribution based on Panels everywhere + Bootstrap theme. Also it contains bunch of contrib modules, which normally should be used on each project.

This distribution is for developers who knows what they want.

git clone http://git.drupal.org/sandbox/csandanov/1652992.git drupaljedi

https://drupal.org/sandbox/csandanov/1652992

Demo site will available soon on domain http://drupaljedi.org

Comments

davidmac’s picture

Hi,

You should remove the Git master branch or set the default to the version branch. https://drupal.org/node/1127732

csandanov’s picture

@davidmac, thanks for your feedback.

Master branch has been removed.

PA robot’s picture

Status:Needs review» Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxcsandanov1652992git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

csandanov’s picture

Status:Needs work» Needs review

It seems PA robot checked this distribution as it was a module.

klausi’s picture

Status:Needs review» Needs work

That is fine. There should not be a full Drupal in the repository, only the installation profile and drush make scripts. See https://drupal.org/node/159730

csandanov’s picture

Status:Needs work» Needs review

I've changed it according to https://drupal.org/developing/distributions/drupalorg
Is there any way to test distribution as it was downloaded as release before approve?

I also check it with PA robot, most of the errors concern version and project lines in .info files of features.
How can I make him ignore it?

davidmac’s picture

You aren't required to correct markup errors in projects that you don't have commit access to. If you are just packaging existing projects into a distro, then it should suffice to make sure that any files you create meet the guidelines. It's a good idea to explain here if the distro contains any new contributed code written by yourself or your dev team. I see that you are using a fork of the deprecated twitter bootstrap theme (twitter_bootstrap_panels_everywhere), and your forked project includes the comment:

Current version under active development and could not be used on production servers.

Although this shouldn't cause you many problems, it is worth mentioning it in the project description, and making potential users explicitly aware of this. Why? well because a packaged distro suggests all projects inside it are ready for distribution, although you do mention that it is for developers.

You are including a few new modules such as the drupal jedi module, which should be dependent on the views module no? in it's .info file. They should all meet the coding standards.

My opinion is to ignore the errors in pareview.sh that are not related to code you have written or altered. If you want the script to ignore certain folders, simply review your custom folders individually.

csandanov’s picture

@davidmac, thanks for you feedback. I've added views to dependcies

Twitter bootstrap theme for panels will be updated soon to bootstrap 3, my colleagues already working on it
Meanwhile, it would be nice to receive full access for project and continue it's active development
I need it because now I can't see how complete distribution will look like when it's downloaded in regular way (https://drupal.org/developing/distributions/drupalorg step 6).

Or may be someone could tell me how to assemble complete distribution with drupal code, my profile and all contrib modules

davidmac’s picture

As I understand it, your disto contains new modules/projects that you are submitting for the first time. So normally they, and yourself, would go through the approval process like other contrib projects and developers.

That's why I'd mentioned:

It's a good idea to explain here if the distro contains any new contributed code written by yourself or your dev team

Can you detail the new code that needs to be reviewed to help the process along?

Alternatively, you could ask one of your colleagues to promote it to a full project if it is urgent, as I understand it, iRuslan has the required privileges.

It may well be that there are exceptions where teams are involved, however I'm not aware of any.

Also see comment #3, if you want to use the review bonus system to hurry things along.

csandanov’s picture

@davidmac, thanks for you reply

I added my colleague IRuslan to project and he approved it https://drupal.org/project/drupaljedi
Looks like drupal bug for me

That's why I'd mentioned:

It's a good idea to explain here if the distro contains any new contributed code written by yourself or your dev team

Can you detail the new code that needs to be reviewed to help the process along?

Distribution will have custom code like https://drupal.org/project/commerce_kickstart
This code will be used to make distribution more user-friendly and provide some default configuration

And I have a new question:

I pushed some changes in dev branch, but I don't see any commits on project page
Is it caused because I do it in development release?

davidmac’s picture

Status:Needs review» Postponed

It's not a Drupal bug, it's just that you need to go through the approval process (for your username) like your colleague did. I'm sure he can explain the process to you.

In order to have a recommended release (color coded green) for your project, you need to 'tag' a release version in your Git repo (then push it up) and then enable it using the link at the bottom of your project page.

See:
https://drupal.org/node/1066342
https://drupal.org/node/1068944

I've set this to 'postponed' as your project is published. If you want to go through the approval process, you need to submit code that you have written yourself, such as a module or theme and create a new issue for it. This issue will be closed if no longer active.

davidmac’s picture

Issue summary:View changes

Add link to project page

davidmac’s picture

Issue summary:View changes
Status:Postponed» Fixed

Project is already published, therefore review process is no longer relevant.

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.