Matt? I think this one is for you... I think we discussed this at length already. Layouts should be pretty much decoupled from the rest of the theme (there should not be much variable leakage into the layout from the theme actually, even though we currently do that for certain things). But the colors for the header and that pattern in the background for things like the footer is not supposed to be in the layout, or?

Hmm, I think we may need layout-dependent theme styles?

Comments

fubhy’s picture

fubhy CreditAttribution: fubhy commented

This comment also mentions some flaws in Ohm Hero: https://drupal.org/node/2058719#comment-7866595

msmithcti’s picture

msmithcti CreditAttribution: msmithcti commented

This is related to the discussion we had on renaming the Ohm Hero layout to just "Hero" which is the direction I want to go in. For that to happen we need to remove Ohm specific things and make sure we don't have variables shared between them.

IMO this worked fine when this layout was just for Ohm, and named in that way. They are definitely layout styles as far as SMACSS is concerned (they certainly aren't base or components) so when I'm using Omega layouts on projects I include these kinds of styles in there and share variables such as vertical spacing.

I will take a look at this and work the Ohm specific styles into sensible places within the theme. Then that gives us one more generic layout in our collection!

fubhy’s picture

fubhy CreditAttribution: fubhy commented

Well, what do you think about layout specific theme CSS? So each layout comes with a layout.scss file and a styles.scss file that would control the looks of it?

msmithcti’s picture

msmithcti CreditAttribution: msmithcti commented
Assigned: msmithcti » Unassigned
Status: Active » Fixed

Fixed in 2aaa95b.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.