core/modules is large, so splitting roughly in half, A-L and M-Z. This is A-L. M-Z is #2089471: Convert all calls to check_plain() in core to Drupal\Component\Utility\String::checkPlain() in core/modules/M-Z (except system/simpletest).

Part of #2089331: [meta] Replace calls to check_plain() with Drupal\Component\Utility\String::checkPlain().

CommentFileSizeAuthor
#31 check_plain_to_String_checkPlain-2089465-31.patch68.33 KBInternetDevels
#29 check_plain_to_String_checkPlain-2089465-29.patch68.09 KBchr.fritsch
#25 check_plain_to_String_checkPlain-2089465-25-FAILS.patch76.94 KBnetsensei
#25 check_plain_to_String_checkPlain-2089465-25.patch77.12 KBnetsensei
#25 interdiff.txt367 bytesnetsensei
#21 check_plain_to_String_checkPlain-2089465-21.patch76.84 KBrpsu
#21 interdiff.check_plain_to_String_checkPlain-2089465-21.txt1.6 KBrpsu
#17 check_plain_to_String_checkPlain-2089465-17.patch76.84 KBrpsu
#15 2089465-15.patch76.05 KBthedavidmeister
#11 check_plain_to_String_checkPlain-2089465-11.patch23.18 KBsandipmkhairnar
#8 2089465-8.patch76.05 KBthedavidmeister
#6 2089465-3-6-interdiff.txt1.19 KBthedavidmeister
#6 2089465-6.patch76 KBthedavidmeister
#4 2089465-2-3-interdiff.txt654 bytesthedavidmeister
#4 2089465-3.patch75.76 KBthedavidmeister
#2 2089465-2.patch75.65 KBthedavidmeister
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

thedavidmeister’s picture

thedavidmeister CreditAttribution: thedavidmeister commented
Issue tags: +Novice
thedavidmeister’s picture

thedavidmeister CreditAttribution: thedavidmeister commented
Status: Active » Needs review
FileSize
2089465-2.patch75.65 KB

Status: Needs review » Needs work

The last submitted patch, 2089465-2.patch, failed testing.

thedavidmeister’s picture

thedavidmeister CreditAttribution: thedavidmeister commented
Status: Needs work » Needs review
FileSize
2089465-3.patch75.76 KB
2089465-2-3-interdiff.txt654 bytes

Status: Needs review » Needs work

The last submitted patch, 2089465-3.patch, failed testing.

thedavidmeister’s picture

thedavidmeister CreditAttribution: thedavidmeister commented
Status: Needs work » Needs review
FileSize
2089465-6.patch76 KB
2089465-3-6-interdiff.txt1.19 KB

Status: Needs review » Needs work

The last submitted patch, 2089465-6.patch, failed testing.

thedavidmeister’s picture

thedavidmeister CreditAttribution: thedavidmeister commented
Status: Needs work » Needs review
FileSize
2089465-8.patch76.05 KB

Status: Needs review » Needs work

The last submitted patch, 2089465-8.patch, failed testing.

sidharthap’s picture

sidharthap
Primary language English
CreditAttribution: sidharthap commented

I tried the patch on D8 fresh installation but it is get failed.

sandipmkhairnar’s picture

sandipmkhairnar CreditAttribution: sandipmkhairnar commented
FileSize
check_plain_to_String_checkPlain-2089465-11.patch23.18 KB
mcrittenden’s picture

mcrittenden CreditAttribution: mcrittenden commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, check_plain_to_String_checkPlain-2089465-11.patch, failed testing.

thedavidmeister’s picture

thedavidmeister CreditAttribution: thedavidmeister commented
Assigned: Unassigned » thedavidmeister

#11 is missing lots of use Drupal\Component\Utility\String; lines and is less than half the size of #8. I'm going to re-roll #8.

thedavidmeister’s picture

thedavidmeister CreditAttribution: thedavidmeister commented
Status: Needs work » Needs review
FileSize
2089465-15.patch76.05 KB

reroll

Status: Needs review » Needs work

The last submitted patch, 2089465-15.patch, failed testing.

rpsu’s picture

rpsu
he/him
Primary language Finnish
CreditAttribution: rpsu commented
Status: Needs work » Needs review
FileSize
check_plain_to_String_checkPlain-2089465-17.patch76.84 KB

Found one more check_plain, which is now also replaced.

Status: Needs review » Needs work
Issue tags: -Novice

The last submitted patch, check_plain_to_String_checkPlain-2089465-17.patch, failed testing.

rpsu’s picture

rpsu
he/him
Primary language Finnish
CreditAttribution: rpsu commented
Status: Needs work » Needs review

#17: check_plain_to_String_checkPlain-2089465-17.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice

The last submitted patch, check_plain_to_String_checkPlain-2089465-17.patch, failed testing.

rpsu’s picture

rpsu
he/him
Primary language Finnish
CreditAttribution: rpsu commented
FileSize
interdiff.check_plain_to_String_checkPlain-2089465-21.txt1.6 KB
check_plain_to_String_checkPlain-2089465-21.patch76.84 KB

This patch makes Path tests to fail, but I don't seem to find where tested path alias is or should be set? Locally that test passes, though.

rpsu’s picture

rpsu
he/him
Primary language Finnish
CreditAttribution: rpsu commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, check_plain_to_String_checkPlain-2089465-21.patch, failed testing.

netsensei’s picture

netsensei CreditAttribution: netsensei commented

Hm. Patch doesn't apply to HEAD anymore.

netsensei’s picture

netsensei CreditAttribution: netsensei commented
FileSize
interdiff.txt367 bytes
check_plain_to_String_checkPlain-2089465-25.patch77.12 KB
check_plain_to_String_checkPlain-2089465-25-FAILS.patch76.94 KB

Chasing HEAD + Fixed the problem with forum tests failing: another missing use Drupal\Component\Utility\String in forum.module

Let's see...

netsensei’s picture

netsensei CreditAttribution: netsensei commented
Status: Needs work » Needs review

Hm. Forgot to set status.

netsensei’s picture

netsensei CreditAttribution: netsensei commented
Issue summary: View changes

Updated issue summary.

areke’s picture

areke CreditAttribution: areke commented
Issue summary: View changes
Status: Needs review » Needs work

And this doesn't apply anymore... It seems that we're going to have to continue chasing HEAD, since this affects so many files.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Issue tags: +@deprecated
chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch commented
Status: Needs work » Needs review
FileSize
check_plain_to_String_checkPlain-2089465-29.patch68.09 KB

Status: Needs review » Needs work

The last submitted patch, 29: check_plain_to_String_checkPlain-2089465-29.patch, failed testing.

InternetDevels’s picture

InternetDevels CreditAttribution: InternetDevels commented
Status: Needs work » Needs review
FileSize
check_plain_to_String_checkPlain-2089465-31.patch68.33 KB
InternetDevels’s picture

InternetDevels CreditAttribution: InternetDevels commented

Status: Needs review » Needs work

The last submitted patch, 31: check_plain_to_String_checkPlain-2089465-31.patch, failed testing.

thedavidmeister’s picture

thedavidmeister CreditAttribution: thedavidmeister commented

#2196797: Convert all calls to check_plain() in core to Drupal\Component\Utility\String::checkPlain() in action module

thedavidmeister’s picture

thedavidmeister CreditAttribution: thedavidmeister commented
Status: Needs work » Closed (duplicate)
Parent issue: » #2089331: [meta] Replace calls to check_plain() with Drupal\Component\Utility\String::checkPlain()

I'm going to close this as a duplicate. Please see the parent issue for smaller issues that are more committable.

Thanks to everyone for their hard work re-rolling this over and over, I hope to see you all in the mini issues!