[D7] Address Field JP

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://drupal.org/node/2089425

Project 2: https://drupal.org/node/2081543

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello,

Drupal 7.23: I successfully installed the module after installing the required module "Address Field" - https://drupal.org/project/addressfield

Individuals interested in this module, most likely, will have an idea how and where its functionality might be useful. I, however, don't have a clue because I don't have a need for this yet.

I'm interested in giving it a try though since my own website doesn't just target a specific language.

Some small suggestions:

Please provide just a little more detail on the project page. I know it's pretty apparent when you mention "This module provides a Japanese address form for Address Field."

Perhaps you can also provide a link to the "Address Field" module, listing it as a dependency. Maybe that in itself would provide enough information for those new to the use of the Address Field. This is only a small suggestion in line with the "Module documentation guidelines" (https://drupal.org/node/161085)

Thanks for your efforts!

I installed the module with address field created a new content type selected address field with dynamic address checked the additional box that your module provides and then viewed the address field in the context of a node creation. The fields were reordered to your specification and province options for Japan became available.

The code looks fine and complies with coding standards.

This module needs a README.txt where you could briefly describe the steps to use your newly provided japan specific address options.

Other than that this works well functionally and the code is to standard.

Cheers!

Although i can see that you would like to keep this as a separate project, I believe there is an opportunity for collaboration between this project and address field.
I suggest you get in touch with maintainers and addressfield and submit a patch.

The is a simple and effective module, I found it quite easy to install, as we use the address field a lot, but one thing you could do is to make a picture of the settings page for easy activation on the project page.

You could improve the README.txt of the module.

Else the code is very small to review.
The could use the following template

-- SUMMARY --
Put a summary here.

-- REQUIREMENTS --
Put requirements here. Dependencies etc.

-- INSTALLATION --
Put installation instructions here.

-- USAGE --
Put usage instructions here.

Refer to README.txt of some well know contributed module.

https://groups.drupal.org/node/195848 link could be useful for you.

@klausi: Could you guide here. Does the rule still apply i.e.: any module less than 5 functions or less than 120 lines of code, could not be reviewed to allow a user to promote to git vetted user. Am I missing something here.

Possible Duplication

It seems that Address Field provides very similar functionality. Could you describe how your module differs?

We prefer collaboration over competition, therefore we want to prevent having duplicating modules on drupal.org. If the differences between these modules are not too fundamental for patching the existing one, we would love to see you joining forces and concentrate all power on enhancing one module. (If the existing module is abandoned, please think about taking it over).

If that fails for whatever reason please get back to us and set this back to "needs review".

There's already a patch to add JP support available at #1107484: Support for Japanese addresses. Please review and test that patch and it will be added to the module for you. As documented in https://drupal.org/node/1665788#comment-7366366 the maintainers are willing to add new country formats.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Downloaded and reviewed. This module works as described.

Note there is a discussion about the Address Field module and the amount of additional modules that is being created to further enhance it. I think the project admins here are reaching out to the developer of Address Field to discuss how to handle all of these additional modules that provide country specific field formaters like this one. I am marking this as reviewed and tested never the less.

@Ichang

See this post: They have discussed with the maintainer of Address field that these type of contributions should go against the core module:

https://groups.drupal.org/comment/reply/383073/996928

Yep, please report back here once that is done.

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.