@see title.

What about this? There is a weird bug with sass-globbing that prevents it from properly working when you try to import with wildcards from a sub-folder of /sass. At least it did not work for me in the ohm-hero layout .scss files.

Also, having the layouts folder in /sass directly next to the partials folders is kinda werid... It's a pitty that we can't have multiple Sass source folders :/.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fubhy’s picture

FileSize
13.5 KB

Oh... Forgot to upload the patch!

fubhy’s picture

Status: Active » Needs review
fubhy’s picture

Note: I also moved some of the form stuff from /base to /components (e.g. the password related one, etc.) as we previously agreed that "base" should be considered pure HTML elements only (with some, rare exceptions).

brst t’s picture

20131102 - removed by author

fubhy’s picture

Also, having the layouts folder in /sass directly next to the partials folders is kinda werid... It's a pitty that we can't have multiple Sass source folders :/.

Yeah, I don't get this at all. I don't understand why it needs separate/special handling and can't just be another component in the first place.

We don't want to have multiple config.rb files. Everything should compile with one compiler running. One should not have to go to multiple places in the theme to run "compass watch". Hence, we moved all .scss files to the global /sass folder so a single compiler run watches all files in the theme. The problem with that is that we can't place the .scss files of our layouts where they actually belong (the folder of the corresponding layout).

This is a limitation of Compass. One can not have multiple source/destination folders. With plain sass that is possible

sass watch sass:css layouts:css/layouts --compass

That command would compile everything from /sass into /css and everything from /layouts into css/layouts.

But that does not work with "compass watch" (or the config.rb rather).

brst t’s picture

20131102 - removed by author

msmithcti’s picture

Really like the restructuring, that does make thing simpler, and prevents us from having two concepts of layouts with in the sass/ directory.

On the base vs. component grey area, generally base styles should be just HTML elements and this is how I explain base styles to people. In some cases (especially in Drupal) this isn't fully attainable, so we shouldn't be too strict in always applying this rule. The more complex groups of elements (like the password) should definitely be a component. My only problem with #1 that we are now splitting up the styling for fieldsets and form items in two different places, which IMO adds confusion.

fubhy’s picture

FileSize
13.47 KB

Okay, granted... form items and fieldsets can stay there...

How do you like this then? The thing with compass not supporting multiple sass_dir and css_dir declarations is really annoying, meh.

fubhy’s picture

FileSize
13.47 KB

Quickly fixing that new-line problem.

fubhy’s picture

Status: Needs review » Fixed

Okay, imho this is good enough to get committed as a first step. We can still tinker with the layouts later. I also changed the extended starterkit accordingly. If there is anything more you would like to improve please open a second step issue and post it here.

brst t’s picture

20131102 - removed by author

fubhy’s picture

.scss, not .css :P

brst t’s picture

dhrr.

Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.