This project loads the Browser Ponies JS library on a page after a user types the Konami Code (up up down down left right left right b a). Because let's face it: what website is complete without OMG PONIES?

Sandbox URL: https://drupal.org/sandbox/rj/2089189
Git: git clone rj@git.drupal.org:sandbox/rj/2089189.git

Comments

bluesomewhere’s picture

Status: Needs review » Needs work

Howdy, RJ! Thanks for adding to the craziness that is the Konami Code :)

Aside from the issues below, please correct your Git clone in the style of:
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/rj/2089189.git browser_ponies

Duplication
This sounds like a feature that should live in the existing Konami Code project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the Konami Code issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

Master Branch
It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Major coding standards / best practice issues
An automated review of your project has found some issues with your code; As coding standards make sure projects are coded in a consistent style we please you to have a look at the report and try to fix them. Anyway, note that issues found are possibly false positives and fixing all issues is not a requirement for getting through the application process.

You can find the results of the automated report at http://pareview.sh/pareview/httpgitdrupalorgsandboxrj2089189git

Also, I suggest taking advantage of the Project Application Review Bonus to expedite review: https://drupal.org/node/1975228

rj’s picture

Status: Needs work » Closed (fixed)

Very cool, I hadn't seen that module, this has been patched against Konami Code:

#2089349: Browser Ponies

rj’s picture

Issue summary: View changes

update URL