[D6] Logman

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxAbhijeetGhosh2030383git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi my friend,

Help with some reviews, 3 at least and put yourself the bonus review tag so other developers will review type module.

Thank you

Hi

I installed this module and took it for a test drive.
I like the idea. Below are the following issues I came across

Error message on page admin/reports/logman
Notice: Undefined offset: 14 in LogmanApacheSearch->readApacheLog() (line 192 of /sites/all/modules/logman/2030383/includes/lib/LogmanApacheSearch.php).

You need to create a hook_uninstall in your .install file and use variable_del. So that your users have the option to remove all of the variables stored in the databases by your module.

Hope that was helpful
T

Review of the 6.x-1.x branch:

• DrupalPractice has found some issues with your code, but could be false positives.
  

  
  FILE: /home/klausi/pareview_temp/includes/lib/LogmanWatchdogSearch.php
  --------------------------------------------------------------------------------
  FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
  --------------------------------------------------------------------------------
   195 | WARNING | Do not call theme functions directly, use theme('pager', ...)
       |         | instead
  --------------------------------------------------------------------------------
  
  
  FILE: /home/klausi/pareview_temp/includes/logman_watchdog.inc
  --------------------------------------------------------------------------------
  FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
  --------------------------------------------------------------------------------
   242 | WARNING | Do not call theme functions directly, use theme('table', ...)
       |         | instead
  --------------------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. There are a lot of similar modules already - you described differences to existing modules, but is yet another new module really necessary? Please reconsider joining forces with an existing project before working further on this.
2. logman_init(): this is run on every single page request, don't do that. Add your CSS and JS when you actually need it (in the page callabck that creates your output).
3. logman_statistics_form(): doc block is wrong, this is not a hook. See https://drupal.org/node/1354#forms
4. interface LogmanSearchInterface: please document all @param and @return variables.
5. class LogmanWatchdogSearch: this looks very vulnerable to SQL injection although it seems like no dangerous user provided text is passed to that function. Always use placeholder in DB queries, make sure to read https://drupal.org/writing-secure-code again. searchLog() looks also dangerous, but it seems pager_query() takes care of variable substitution and I could not exploit anything.
6. notice: Undefined index: values in /home/klausi/workspace/drupal-6/sites/all/modules/logman/logman.module on line 345. Please enable PHP notices in your development environment.

Otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to kscheirer as he might have time to take a final look at this.

Thanks for addressing the similar modules on your project page.

• In logman_watchdog_search_result() why are you setting a date_default_timezone_set("Europe/London"); ?
• In LogmanWatchdogSearch::getStatistics() and other functions, instead of using your own tokens with substitution, you can use db_query() to handle that for you.
• I may have missed it, but I didn't see anyplace you checked that the apache log file is readable?
• For the theme functions, klausi meant that you should call them like theme('pager') instead of directly as theme_pager(). This is done so overrides have a chance to intercept those calls. If you call theme_pager directly, no override can happen.
• Do you plan to release a D7 version of this module?

Very nicely written module!

Thanks for your contribution, abghosh82!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.