ViewsHandlerDiscovery and Core AnnotatedClassDiscovery now no longer need $this->pluginNamespaces inherited from Component AnnotatedClassDiscovery. Instead, plugin lazily are dynamically determined in getPluginNamespaces();

This is since this patch went in:

However, ViewsHandlerDiscovery::__construct() still fills this variable for no reason.
This was introduced before the above mentioned change:

This should be removed.

#1 D8-ViewsHandlerDiscovery-2087551-1.patch1.76 KBdonquixote
PASSED: [[SimpleTest]]: [MySQL] 59,418 pass(es).
[ View ]


donquixote’s picture

Status:Active» Needs review
new1.76 KB
PASSED: [[SimpleTest]]: [MySQL] 59,418 pass(es).
[ View ]
damiankloip’s picture

Status:Needs review» Reviewed & tested by the community

Looks fine to me.

dawehner’s picture

To be honest I would like to understand whether it would be possible to remove the custom discovery mechanism in general.

damiankloip’s picture

It's a good question.

dawehner’s picture

Issue tags:+VDC

We can remove the custom discovery in a follow up.

donquixote’s picture

dawehner: thanks!

This patch will remove yet another obstacle for PSR-4,
#2083547: PSR-4: Putting it all together

webchick’s picture

Status:Reviewed & tested by the community» Fixed

Yay, less code. :)

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary:View changes

give context to the other commit link.