Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The links provided for "Log in using OpenID" and "Cancel OpenID login" are not being presented in a list format similar to or along with the other adjacent items in the block.
In all the themes I've used they flow into one another, separated neither by a new line or even any white space.
See attached clipped view of Garland Scheme for demonstration.
Comment | File | Size | Author |
---|---|---|---|
#1 | openid-ul.patch | 4.55 KB | Pancho |
#1 | OpenID-block1.png | 34.84 KB | Pancho |
#1 | OpenID-block2.png | 35.76 KB | Pancho |
OpenID_UserLogin_List.jpg | 44.17 KB | mwpeters |
Comments
Comment #1
PanchoI figured out how to present the links in a proper list, to switch on/off the whole
<li>
list element and not only the<a>
anchor element, so the item is nicely displayed with the same spacing as the other ones.To make the list semantically right, we would have to merge the two
<ul>
containers, which is not easily done - for this we would actually need to move the $form['links'] builder out of user_login_block(). I can do that, but I think that wouldn't be a good idea now.I also moved "Log in using OpenID" resp. "Cancel OpenID login" further up, so it is listed before "Create new account" and "Request new password". This order makes definitely more sense.
So please apply my patch and test it under different browsers (Firefox 2.0.0.11 and IE7 already tested by myself).
Comment #2
PanchoComment #3
PanchoComment #4
PanchoComment #5
moshe weitzman CreditAttribution: moshe weitzman commentedi tested in safari and opera (OSX) as well and this is an improvement. opera left behind a tiny artifact of text when clicking on 'cancel' but it goes away on window resize. i think thats an extremely minor issue and the benefits of the patch far outweigh it. rtbc.
Comment #6
moshe weitzman CreditAttribution: moshe weitzman commentedif you look at /user/login page with garland, you will see that this fixes a rather ugly UI bug. so i set to critical so we don't release ugliness.
Comment #7
birdmanx35 CreditAttribution: birdmanx35 commentedI just tested this, and it applies cleanly and (as previously mentioned) fixes a rather ugly UI bug in all themes, not just in Garland.
Comment #8
Gábor HojtsyHm, by not setting a { display: block } on the links, the click area becomes different, doesn't it? Did that change? Was that intentional? Also, setting this critical is an exaggeration at the very least, so demoting.
Comment #9
moshe weitzman CreditAttribution: moshe weitzman commentedGabor - It is true that the click area has changed on the /user page (but not on the user block). In the user block, these links have the same click area as the existing request new password and create account links. So now these links are consistent everywhere.
IMO, the click area is a very minor issue. In fact, I am amazed and impressed that you spotted it. I recommend committing this since the its benefits far outweigh the problem. I did try to fix the click area but I couldn't do it - my js+css fu is not strong enough.
I humbly set to RTBC. Please demote it if you disagree.
Comment #10
catchhaven't tested this patch, but click area on links can be done with some height/width in css usually.
Something like:
NB: that may look horrible, not tested this yet, but that's the standard way to force a larger clickable area afaik. min-height and min-width won't work in IE6 but meh. Leaving at RTBC since even if I'm right that could go in a followup patch.
Comment #11
Gábor HojtsyWell, I agree the click area might be a minor issue, if someone is interested, they will submit an issue against that. Committed.
Comment #12
Anonymous (not verified) CreditAttribution: Anonymous commentedAutomatically closed -- issue fixed for two weeks with no activity.