ModuleHandler::isLoaded() returns FALSE immediately after a module is enabled, causing an exception when theme() is called [#2084115]

Whenever the kernel is rebuilt, a new ModuleHandler instance pops into place, which believes that all modules have not be loaded yet in the current page request...

That is broken. Once modules are loaded, they stay loaded, and the code should reflect that.

Comment	File	Size	Author
#2	module-handler-is-loaded-2084115-2-TESTING.patch	2.96 KB	David_Rothstein
#2
#2	module-handler-is-loaded-2084115-2.patch	2.56 KB	David_Rothstein
#2
#1	module-handler-is-loaded-2084115-1-TESTING.patch	407 bytes	David_Rothstein
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

David_Rothstein CreditAttribution: David_Rothstein commented 7 September 2013 at 20:35

Status:

Active

» Needs review

File	Size
module-handler-is-loaded-2084115-1-TESTING.patch	407 bytes

Here's some example code that illustrates the problem. It looks like a harmless patch, but I'm pretty sure it will fail tests spectacularly.

The way I actually ran into it was testing the patches in #734710: API functions that invoke hooks don't work as expected when a disabled module is being uninstalled manually, and trying to uninstall a module with the overlay open. You wind up thrown out of the overlay and with an exception thrown that says "theme() may not be called until all modules are loaded".

Comment #2

David_Rothstein CreditAttribution: David_Rothstein commented 7 September 2013 at 20:42

File	Size
module-handler-is-loaded-2084115-2.patch	2.56 KB

module-handler-is-loaded-2084115-2-TESTING.patch	2.96 KB

And here is a possible fix, although I have no idea what the consequences are. You can see that there's existing code (originally added in #1331486: Move module_invoke_*() and friends to an Extensions class) to work around this issue when unit tests are being run, so I tried removing that too.

This patch definitely improves the situation with #734710: API functions that invoke hooks don't work as expected when a disabled module is being uninstalled - no more exceptions thrown when those patches are used, although there is still a weird issue with the toolbar disappearing after a module is uninstalled in the overlay that may or may not be related to this.

Comment #3

7 September 2013 at 22:26

Status:

Needs review

» Needs work

The last submitted patch, module-handler-is-loaded-2084115-2.patch, failed testing.

Comment #4

jhedstrom

English

Portland, OR

CreditAttribution: jhedstrom commented 25 November 2014 at 19:59

Issue summary:	View changes
Status:	Needs work	» Postponed (maintainer needs more info)

I think with the big refactoring in #2346937: Implement a Renderer service; reduces drupal_render / _theme service container calls, this is no longer an issue. I've tried this code:

/**
 * Implements hook_module_preinstall().
 */
function system_module_preinstall() {
  $renderer = \Drupal::service('renderer');
  $stuff = array('#markup' => 'foo');
  $bar = $renderer->render($stuff);
  drupal_set_message($bar);
}

and cannot reproduce the errors here.