Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
quicksketch
I did the port, I just commited and pushed it into 8.x-1.x
can you review it or make it show up here so I can ask others to review?
thanks! :)
Comments
Comment #1
klonos...less vague title ;)
Comment #2
jibran.module
theme_timezone_picker
can be removed now. I think it is not needed any more.timezone-picker
library can be created formtimezone-picker.css
andtimezone-picker.js
and add proper dependencies.timezone-map.html.twig
lib
folder tolibrary
or something.Comment #3
afeijo@klonos, I just remember that we can change the title by commenting, not under node edit :p Thanks
@jibran,
1. if I remove the timezone_picker_theme, the map disapears :)
it is needed to load the templates\timezone-map.html.twig file. I just tested it to confirm.
2. if we will have the timezone-picker.* files under lib folder, that should be named libs or libraries.
3. Saw no problems with the indentation. Can you be more specific?
I think we should change the map width to a bit bigger, 700px maybe
and the default scheme should be Blue marble or Living earth. Hell we should display the Night Eletric scheme if the user localtime is after 7 pm!! :D
Those should be configurable, shall I implement that admin page?
Changing status to active, since we have no patches in this issue. My bad.
Comment #4
quicksketchtheme_* functions are being removed entirely from Drupal 8, so you'll need to find a way to eliminate the use of theme_timezone_picker() and either convert it to a twig file also, or kill it entirely.
/lib is actually reserved for PHP classes I believe. I would suggest renaming the current /lib directory to /js. If you'd like to consider it an external library, it should be in a /vendor/timezone_picker directory. I personally don't really consider timezone picker to be a "library" so much as a service website that provides a template to be copied, so I don't think using /vendor is a necessity.