I have some sheetnodes that are quite wide, but fit fine on my screen, however when viewed on a tablet don't stay within the content area in my responsive theme. Is there a way to make the sheetnode within the content area responsive as well?

Thanks
Sharon

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sk2013’s picture

Issue summary: View changes

+1

willhallonline’s picture

I am looking at this as part of looking at socialcalc, which I think is the problem more than the integration with the module. I have made a couple of pull requests to the project and I am looking at whether there are slight improvements we can make.

sk2013’s picture

This is a great module No Doubt. As we are going " Smart" adhering to responsiveness will promote more usage and it will be more user friendly.

willhallonline’s picture

Status: Active » Needs review
FileSize
1.1 KB
273 bytes

OK. I have spent a little time looking at this. The main issues that I see are in the toolbar and the function input text. Unfortunately, the answer to solving these two issues are in two separate places.

The Toolbar

You need to change the socialcalc JavaScript (sorry). I will see if I can get it committed into ethercalc and to socialcalc on github so it should help others in the future.

I have added a patch to do this (https://www.drupal.org/files/issues/socialcalc-responsive-sheetnode-2082...), however, hopefully we can improve it slightly more.

The Function Text Box

You can change socialcalc.css to remove this:
line 31: width: auto !important;
to this:
line 31: width: 60%;

I have added a patch (https://www.drupal.org/files/issues/sheetnode-responsive-2082465.patch) to do this also. I will also look at committing this to the latest dev release (7.x-1.x-dev).

sk2013’s picture

Thank you for your effort willhallonline !

It is great to have you here and for this wonderful module. I will apply the patch in the coming days and let you know how it is working.

Thanks
SK2013

willhallonline’s picture

OK there are a bunch more issues largely with the original socialcalc implementation rather than the module. I am working on an new version of socialcalc, which removes quite a bit of the inline css and should respond much better across all devices or browser widths.

Just wanted to keep this issue updated.

willhallonline’s picture

At the moment I have a re-write of some parts of the original socialcalc library which will enable that to be displayed responsively. I have a pull request against https://github.com/infojunkie/socialcalc or you can look at https://github.com/willhallonline/socialcalc for what the changes are (there a quite a few on the editing system).

infojunkie’s picture

I merged the responsive pull request in Github. Thanks!

willhallonline’s picture

Status: Needs review » Closed (fixed)

I have pushed this to the latest version of the socialcalc repo and done quite a bit of work on that. If you want responsive sheetnodes, then go and download the latest version. http://github.com/infojunkie/socialcalc

Amalan’s picture

I have applied the patch but the responsive is working on the edit mode not working on the view mode where the user might see it.