Here is a followup for issue: https://drupal.org/node/2067229

Patch is on its way.

CommentFileSizeAuthor
#7 2081579-7-libraries-search-paths-alter.patch624 bytesemarchak
#2 base_profile-2081579.patch698 bytesumtj
#1 base_profile-2081579-1.patch670 bytesumtj
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

umtj’s picture

umtj CreditAttribution: umtj commented
Status: Active » Needs review
FileSize
base_profile-2081579-1.patch670 bytes
umtj’s picture

umtj CreditAttribution: umtj commented
FileSize
base_profile-2081579.patch698 bytes

Path corrected, sorry.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Needs review » Postponed

I'd surely love to add this feature. But I don't see much value in adding this until the Drupal core issue is in. So marking postponed, unless you can make a compelling case :-).

david.lukac’s picture

david.lukac CreditAttribution: david.lukac as a volunteer commented
Issue summary: View changes

Definitely +1 for this one. We work with install profiles most of the time and having modules support 'base' profiles would be a great advantage.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler as a volunteer commented
Status: Postponed » Closed (won't fix)

So I don't see this getting into core in any way, so closing this one.

What I would be open to is the following: If someone is able to implement this functionality as a *module* (no idea if that possible, but just assuming that it is for now), then I would totally be fine doing a module_exists() check in libraries_get_libraries() in order to support base profiles. If that happens, please do re-open this issue.

I really think base profiles are a pretty cool feature and I would love to have them in core, but that's not something I can control, and since they currently aren't I don't think it makes sense for Libraries API to be "forward-supporting" of some very distant core feature.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler as a volunteer commented

Marked #2733787: Allow install profiles include libraries from their base profile as duplicate.

emarchak’s picture

emarchak CreditAttribution: emarchak at Myplanet commented
FileSize
2081579-7-libraries-search-paths-alter.patch624 bytes

Re-posting the patch from https://www.drupal.org/node/2733787 in case someone else is looking for a patch that isn't three years old.

We included a small alter in the libraries module to allow us to include new library locations via hook_libraries_search_path_alter(). While adjusting the base profiles to inherit libraries properly would be ideal, this solution is small enough for our implementation.

scott shipman’s picture

scott shipman CreditAttribution: scott shipman as a volunteer commented

@tstoeckler , I can understand your hesitation for this proposed patch, when viewed myopically from the perspective of the drupal core lack of progress on sub profiling. But this patch has wider reaching capabilities - such as allowing a developer to provide custom library locations via a hook, for any reason. It could also help to clear a way for a resolution on the sub-profiling issues in drupal core.

Its non-destructive, backwards compatible and trivial in processing costs. I vote to include it.

emarchak’s picture

emarchak CreditAttribution: emarchak at Myplanet commented

@tstoeckler, if we want to make progress on the module_exists approach, should we reopen this issue or create a new one?