Cast $params to array if it is not in bbb_init_meeting and bbb_update_meeting.

$node->bbb is after node build an object, but during node creation it seems to be an array. This will issue an error in array_merge() on (at least) node_update. Casting to array seems to be quick solution for that, however using both array and object structures seems not the clearest way to handle bbb-data in general.

CommentFileSizeAuthor
#8 bbb-cast-params-as-array-if-need-2081365-8.patch649 bytesrpsu
#6 bbb-cast-params-as-array-if-need-2081365-6.patch727 bytesrpsu
#3 bbb-cast-params-as-array-if-need-2081365-3.patch804 bytesrpsu
#1 bbb-cast-params-as-array-if-need-2081365-1.patch703 bytesrpsu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rpsu’s picture

rpsu
he/him
Primary language Finnish
CreditAttribution: rpsu commented
Priority: Normal » Major
Status: Active » Needs review
FileSize
bbb-cast-params-as-array-if-need-2081365-1.patch703 bytes

Updating Priority to major, as automated bbb-node creation fails because of this bug.

It seems like sometimes $node->bbb is object, but sometimes it is an array. Casting solves this type-juggling, but it is just a workaround.

Status: Needs review » Needs work

The last submitted patch, bbb-cast-params-as-array-if-need-2081365-1.patch, failed testing.

rpsu’s picture

rpsu
he/him
Primary language Finnish
CreditAttribution: rpsu commented
FileSize
bbb-cast-params-as-array-if-need-2081365-3.patch804 bytes
rpsu’s picture

rpsu
he/him
Primary language Finnish
CreditAttribution: rpsu commented
Status: Needs work » Needs review
rpsu’s picture

rpsu
he/him
Primary language Finnish
CreditAttribution: rpsu commented
Status: Needs review » Needs work

Apparently I did not test this properly. Not yet ready.

rpsu’s picture

rpsu
he/him
Primary language Finnish
CreditAttribution: rpsu commented
Status: Needs work » Needs review
FileSize
bbb-cast-params-as-array-if-need-2081365-6.patch727 bytes

Perhaps this works better, casting objects to arrays in two places.

Status: Needs review » Needs work

The last submitted patch, bbb-cast-params-as-array-if-need-2081365-6.patch, failed testing.

rpsu’s picture

rpsu
he/him
Primary language Finnish
CreditAttribution: rpsu commented
Status: Needs work » Needs review
FileSize
bbb-cast-params-as-array-if-need-2081365-8.patch649 bytes
rpsu’s picture

rpsu
he/him
Primary language Finnish
CreditAttribution: rpsu commented
Issue summary: View changes

Improved issue description

  • sanduhrs committed fccb65a on 7.x-1.x authored by rpsu 
    Issue #2081365 by rpsu: Cast params as array if needed
sanduhrs’s picture

sanduhrs
he/him
Primary language German
Location 🇪🇺 Heidelberg, Germany, Europe
CreditAttribution: sanduhrs at erdfisch commented
Issue summary: View changes
Status: Needs review » Fixed

Committed, thanks for the patch.

  • sanduhrs committed 06d467f on 7.x-1.x 
    Issue #2081365 by sanduhrs: Views attend and moderate links are broken

  • sanduhrs committed ea2738c on 7.x-1.x 
    Revert "Issue #2081365 by sanduhrs: Views attend and moderate links are...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.