Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/file/lib/Drupal/file/Plugin/field/formatter/FileFormatterBase.php

Line 24: Unused local variable $delta
Line 36: Unused local variable $delta

CommentFileSizeAuthor
#1 drupal-core-remove-unused-local-variable-2081203.patch1.29 KBmrsinguyen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mrsinguyen’s picture

mrsinguyen CreditAttribution: mrsinguyen commented
Status: Active » Needs review
FileSize
drupal-core-remove-unused-local-variable-2081203.patch1.29 KB
royal121’s picture

royal121 CreditAttribution: royal121 commented

Patch failed to apply.

TR’s picture

TR CreditAttribution: TR commented

1: drupal-core-remove-unused-local-variable-2081203.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: drupal-core-remove-unused-local-variable-2081203.patch, failed testing.

areke’s picture

areke CreditAttribution: areke commented
Issue summary: View changes
Status: Needs work » Fixed

The function prepareView() now only takes one argument, which is $entities_items. It looks like when this change was made, the unused variables were removed so this is no longer an issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.